openstack/sushy
Code Issues Proposed changes

Finalize the enum migration

Browse Source 
Change-Id: Id8ab12441a490d49b30c21c4ab6853787631d4c7
This commit is contained in:
Dmitry Tantsur
2021-11-25 13:39:27 +01:00
parent d5aab5ff16
commit e7274e5b7c
7 changed files with 29 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sushy/tests/unit/resources/chassis/test_chassis.py
View File

@@ -57,8 +57,7 @@ class ChassisTestCase(base.TestCase):
self.chassis.uuid)
self.assertEqual(sushy.IndicatorLED.OFF,
self.chassis.indicator_led)
self.assertEqual(sushy.POWER_STATE_ON,
self.chassis.power_state)
self.assertEqual(sushy.PowerState.ON, self.chassis.power_state)
self.assertEqual(sushy.State.ENABLED, self.chassis.status.state)
self.assertEqual(44.45, self.chassis.height_mm)
self.assertEqual(431.8, self.chassis.width_mm)
@@ -81,7 +80,7 @@ class ChassisTestCase(base.TestCase):
self.assertEqual('Blade', attributes.get('name'))
self.assertEqual(sushy.IndicatorLED.OFF,
attributes.get('indicator_led'))
self.assertEqual(sushy.POWER_STATE_ON, attributes.get('power_state'))
self.assertEqual(sushy.PowerState.ON, attributes.get('power_state'))
self.assertEqual({'intrusion_sensor': sushy.IntrusionSensor.NORMAL,
'intrusion_sensor_number': 123,
'intrusion_sensor_re_arm':

2
sushy/tests/unit/resources/system/storage/test_drive.py
View File

@@ -46,7 +46,7 @@ class DriveTestCase(base.TestCase):
self.assertIsInstance(identifiers, list)
self.assertEqual(1, len(identifiers))
identifier = identifiers[0]
self.assertEqual(sushy.DURABLE_NAME_FORMAT_NAA,
self.assertEqual(sushy.DurableNameFormat.NAA,
identifier.durable_name_format)
self.assertEqual('32ADF365C6C1B7BD', identifier.durable_name)
self.assertEqual('Contoso', self.stor_drive.manufacturer)

2
sushy/tests/unit/resources/system/storage/test_storage.py
View File

@@ -125,7 +125,7 @@ class StorageTestCase(base.TestCase):
self.assertIsInstance(identifiers, list)
self.assertEqual(1, len(identifiers))
identifier = identifiers[0]
self.assertEqual(sushy.DURABLE_NAME_FORMAT_NAA,
self.assertEqual(sushy.DurableNameFormat.NAA,
identifier.durable_name_format)
self.assertEqual('345C59DBD970859C', identifier.durable_name)
self.assertEqual(12, controller.speed_gbps)

2
sushy/tests/unit/resources/system/storage/test_volume.py
View File

@@ -50,7 +50,7 @@ class VolumeTestCase(base.TestCase):
self.assertIsInstance(identifiers, list)
self.assertEqual(1, len(identifiers))
identifier = identifiers[0]
self.assertEqual(sushy.DURABLE_NAME_FORMAT_UUID,
self.assertEqual(sushy.DurableNameFormat.UUID,
identifier.durable_name_format)
self.assertEqual('38f1818b-111e-463a-aa19-fa54f792e468',
identifier.durable_name)

3
sushy/tests/unit/resources/system/test_system.py
View File

@@ -68,8 +68,7 @@ class SystemTestCase(base.TestCase):
self.assertEqual(res_cons.Health.OK, self.sys_inst.status.health)
self.assertEqual(res_cons.Health.OK,
self.sys_inst.status.health_rollup)
self.assertEqual(sushy.SYSTEM_POWER_STATE_ON,
self.sys_inst.power_state)
self.assertEqual(sushy.PowerState.ON, self.sys_inst.power_state)
self.assertEqual(96, self.sys_inst.memory_summary.size_gib)
self.assertEqual("OK", self.sys_inst.memory_summary.health)
self.assertIsNotNone(self.sys_inst.maintenance_window)