openstack/sushy
Code Issues Proposed changes

Merge "Fix crashing BasicAuth context manager"

Browse Source
This commit is contained in:
Zuul 2018-10-17 15:28:29 +00:00 committed by Gerrit Code Review
commit eefbfdd4f0
2 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sushy/auth.py
View File

@ -69,6 +69,12 @@ class AuthBase(object):
def can_refresh_session(self):
"""Method to assert if session based refresh can be done."""
def close(self):
"""Shutdown Redfish authentication object
Undoes whatever should be undone to cancel authenticated session.
"""
def __enter__(self):
"""Allow object to be called with the 'with' statement."""
return self

22
sushy/tests/unit/test_auth.py
View File

@ -63,6 +63,13 @@ class BasicAuthTestCase(base.TestCase):
def test_can_refresh_session(self):
self.assertFalse(self.base_auth.can_refresh_session())
@mock.patch.object(auth.BasicAuth, 'close', autospec=True)
def test_context_manager(self, auth_close):
with auth.BasicAuth(self.username, self.password) as base_auth:
self.assertEqual(self.username, base_auth._username)
self.assertEqual(self.password, base_auth._password)
auth_close.assert_called_once_with(base_auth)
class SessionAuthTestCase(base.TestCase):
@ -193,6 +200,13 @@ class SessionAuthTestCase(base.TestCase):
self.assertIsNone(self.sess_auth.get_session_resource_id())
self.assertIsNone(self.sess_auth.get_session_key())
@mock.patch.object(auth.SessionAuth, 'close', autospec=True)
def test_context_manager(self, auth_close):
with auth.SessionAuth(self.username, self.password) as session_auth:
self.assertEqual(self.username, session_auth._username)
self.assertEqual(self.password, session_auth._password)
auth_close.assert_called_once_with(session_auth)
class SessionOrBasicAuthTestCase(base.TestCase):
@ -331,3 +345,11 @@ class SessionOrBasicAuthTestCase(base.TestCase):
self.conn.delete.assert_called_once_with(self.sess_uri)
self.assertIsNone(self.sess_basic_auth.get_session_resource_id())
self.assertIsNone(self.sess_basic_auth.get_session_key())
@mock.patch.object(auth.SessionOrBasicAuth, 'close', autospec=True)
def test_context_manager(self, auth_close):
with auth.SessionOrBasicAuth(
self.username, self.password) as session_or_base_auth:
self.assertEqual(self.username, session_or_base_auth._username)
self.assertEqual(self.password, session_or_base_auth._password)
auth_close.assert_called_once_with(session_or_base_auth)