From 03abd2726553af6983ee712e6ace5880f94dfe2d Mon Sep 17 00:00:00 2001 From: Gerrit User 15343 <15343@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 17 Feb 2023 22:42:31 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (2 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 1179 \u003c1179@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15343\u003e replied on the change"} --- 0fe85015dbef0655f70fcdb0084f1a37ec169924 | 35 ++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/0fe85015dbef0655f70fcdb0084f1a37ec169924 b/0fe85015dbef0655f70fcdb0084f1a37ec169924 index 9df380a..bcb0e49 100644 --- a/0fe85015dbef0655f70fcdb0084f1a37ec169924 +++ b/0fe85015dbef0655f70fcdb0084f1a37ec169924 @@ -51,6 +51,23 @@ "revId": "0fe85015dbef0655f70fcdb0084f1a37ec169924", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "752a3ff9_01863b12", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 15343 + }, + "writtenOn": "2023-02-17T22:42:31Z", + "side": 1, + "message": "Do we like the direction Matt\u0027s taking with https://review.opendev.org/c/openstack/swift-bench/+/866826? Assuming we do, I might work on a optparse-\u003eargparse patch on top of it, then stack *this* on top of *that*...", + "revId": "0fe85015dbef0655f70fcdb0084f1a37ec169924", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -84,6 +101,24 @@ "message": "i notice in this branch we convert options.num_containers to an int before we use it as such\n\nOMM when I tried to test this with `num_containers \u003d 1` in my bench.conf on my vsaio, I still got a container named `d9b155a78c3e41ccbdf2457ee55a2de8_0`\n\nusing pdb it appears this is because `options.num_containers \u003d\u003d \u00271\u0027` but `options.num_containers \u003d\u003d 1` is False", "revId": "0fe85015dbef0655f70fcdb0084f1a37ec169924", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "e666687a_2d07b8ce", + "filename": "bin/swift-bench", + "patchSetId": 2 + }, + "lineNbr": 164, + "author": { + "id": 15343 + }, + "writtenOn": "2023-02-17T22:42:31Z", + "side": 1, + "message": "Yeah, we probably should add `type\u003dint` all over the place when we\u0027re defining the parser.\n\nAlso, we should switch to argparse.\n\nOr, if that\u0027s a bit much yak to shave, just check `if int(options.num_containers) \u003d\u003d 1`.", + "parentUuid": "a86240a7_01121d55", + "revId": "0fe85015dbef0655f70fcdb0084f1a37ec169924", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file