From 020b5a78a537759f1fb99e6b00dc43fe17aeb9c0 Mon Sep 17 00:00:00 2001 From: Alistair Coles Date: Mon, 7 Apr 2025 15:23:20 +0100 Subject: [PATCH] trivial: statsd tests: remove references to delegate methods Some tests previously made assertions on statsd client methods that were implemented by a delegated interface patched onto a logger instance. Those tests have run against a StatsdClient since the Related Change, so the use of the term 'delegate' in tests no longer makes sense. Change-Id: Ie47fa50a226da6ff7b067d6a367758ac9f12ef4c Related-Change: I3a677bb67c5700da48f89c847f652b4610ba47c2 --- test/unit/common/test_statsd_client.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test/unit/common/test_statsd_client.py b/test/unit/common/test_statsd_client.py index 5213efb2fd..e8dbca26a0 100644 --- a/test/unit/common/test_statsd_client.py +++ b/test/unit/common/test_statsd_client.py @@ -712,7 +712,6 @@ class TestGetStatsdClientOutput(BaseTestStatsdClientOutput): # No "log_statsd_host" means "disabled" 'log_statsd_port': str(self.port), }, 'some-name') - # Delegate methods are no-ops self.assertIsNone(self.client.update_stats('foo', 88)) self.assertIsNone(self.client.update_stats('foo', 88, 0.57)) self.assertIsNone(self.client.update_stats('foo', 88, @@ -733,7 +732,7 @@ class TestGetStatsdClientOutput(BaseTestStatsdClientOutput): # Now, the queue should be empty (no UDP packets sent) self.assertRaises(Empty, self.queue.get_nowait) - def test_delegate_methods_with_no_default_sample_rate(self): + def test_methods_with_no_default_sample_rate(self): self.client = get_statsd_client({ 'log_statsd_host': 'localhost', 'log_statsd_port': str(self.port), @@ -792,7 +791,7 @@ class TestGetStatsdClientOutput(BaseTestStatsdClientOutput): self.assertStat('another.counter:3|c|@0.939', self.client.update_stats, 'another.counter', 3, 0.939) - def test_delegate_methods_with_default_sample_rate(self): + def test_methods_with_default_sample_rate(self): self.client = get_statsd_client({ 'log_statsd_host': 'localhost', 'log_statsd_port': str(self.port), @@ -844,7 +843,7 @@ class TestGetStatsdClientOutput(BaseTestStatsdClientOutput): self.client.update_stats, 'another.counter', 3, 0.987654) - def test_delegate_methods_with_metric_prefix(self): + def test_methods_with_metric_prefix(self): self.client = get_statsd_client({ 'log_statsd_host': 'localhost', 'log_statsd_port': str(self.port),