openstack
/
swift
Code Issues Proposed changes

This setting should've been set to False back ... 

...with commit 9eb797b099

With this setting to True in the code, any tools anyone writes will
automatically start preallocating, which is almost always bad these days
with SSDs. So, if you write a tool that just scan dbs for stats, it'll
commit any pending info triggering preallocation and bam, your SSDs
start to fill up. :/

Anyway, back when I wrote 9eb797b099 it
was my intention to have this off by default, everywhere; I changed all
the settings points but I failed to change the dang constant itself.
This corrects that.

Change-Id: Iada0a3f1ecfabda4a96f574903d8e2eed1f69064
This commit is contained in:
gholt 2014-07-08 15:14:25 +00:00
parent c94779d2ac
commit 0582db728f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
swift/common/db.py
View File

@ -35,7 +35,7 @@ from swift.common.exceptions import LockTimeout
#: Whether calls will be made to preallocate disk space for database files.
DB_PREALLOCATION = True
DB_PREALLOCATION = False
#: Timeout for trying to connect to a DB
BROKER_TIMEOUT = 25
#: Pickle protocol to use