openstack/swift
Code Issues Proposed changes

Monkey-patch in tests using mock.patch

Browse Source 
Change-Id: Idf2205074e8f12bc0e515c860e9c1bddf59561d1
This commit is contained in:
Tim Burke
2021-01-14 14:11:41 -08:00
parent 267d432f86
commit 14a42d573a
1 changed files with 40 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/unit/common/test_manager.py
View File

@@ -1374,16 +1374,11 @@ class TestServer(unittest.TestCase):
def sleep(self, *args, **kwargs): def sleep(self, *args, **kwargs):
pass pass
with temptree([]) as t: with temptree([]) as t, open(os.path.join(t, 'output'), 'w+') as f, \
old_stdout = sys.stdout mock.patch.object(sys, 'stdout', f), \
old_wait = manager.WARNING_WAIT mock.patch.object(manager, 'WARNING_WAIT', 0.01), \
old_time = manager.time mock.patch.object(manager, 'time', MockTime()):
try: # Note that we actually capture the read stdout (for prints)
manager.WARNING_WAIT = 0.01
manager.time = MockTime()
with open(os.path.join(t, 'output'), 'w+') as f:
# actually capture the read stdout (for prints)
sys.stdout = f
# test closing pipe in subprocess unblocks read # test closing pipe in subprocess unblocks read
with MockProcess() as proc: with MockProcess() as proc:
server.procs = [proc] server.procs = [proc]
@@ -1419,10 +1414,6 @@ class TestServer(unittest.TestCase):
self.assertTrue(proc.is_alive()) self.assertTrue(proc.is_alive())
for proc in procs: for proc in procs:
proc.join() proc.join()
finally:
sys.stdout = old_stdout
manager.WARNING_WAIT = old_wait
manager.time = old_time
def test_interact(self): def test_interact(self):
class MockProcess(object): class MockProcess(object):