Fix bug regarding negative Content-Length headers.

Change-Id: Ib8e2a5271c33f57429a9683db233610416887ea3

swift/proxy/server.py

@@ -1807,6 +1807,9 @@ class BaseApplication(object):
         :param req: webob.Request object
         """
         try:
+            if req.content_length and req.content_length < 0:
+                return HTTPBadRequest(request=req,
+                                      body='Invalid Content-Length')
             try:
                 controller, path_parts = self.get_controller(req.path)
             except ValueError:

test/unit/proxy/test_server.py

@@ -706,6 +706,23 @@ class TestProxyServer(unittest.TestCase):
         resp = app.handle_request(req)
         self.assert_(called[0])
 
+    def test_negative_content_length(self):
+        swift_dir = mkdtemp()
+        try:
+            baseapp = proxy_server.BaseApplication({'swift_dir': swift_dir},
+                FakeMemcache(), NullLoggingHandler(), FakeRing(), FakeRing(),
+                FakeRing())
+            resp = baseapp.handle_request(
+                Request.blank('/', environ={'CONTENT_LENGTH': '-1'}))
+            self.assertEquals(resp.status, '400 Bad Request')
+            self.assertEquals(resp.body, 'Invalid Content-Length')
+            resp = baseapp.handle_request(
+                Request.blank('/', environ={'CONTENT_LENGTH': '-123'}))
+            self.assertEquals(resp.status, '400 Bad Request')
+            self.assertEquals(resp.body, 'Invalid Content-Length')
+        finally:
+            rmtree(swift_dir, ignore_errors=True)
+
 
 class TestObjectController(unittest.TestCase):