openstack/swift
Code Issues Proposed changes

Keep the Usage of exit()/sys.exit() Consistent

Browse Source 
It's better to keep the usage of exit()/sys.exit() consistent
in one file. Furthermore, sys.exit() is considered good to be
used in production code, while exit is for interactive shell.

Change-Id: Ia3092853a648922588e2bc11db37d6decdec1b48
This commit is contained in:
Mingyu Li 2016-02-07 21:41:08 +08:00
parent e6c28c4ac7
commit 3b94bd4540
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bin/swift-oldies
View File

@ -59,7 +59,7 @@ Lists old Swift processes.
listing.append((str(hours), pid, args)) listing.append((str(hours), pid, args))
if not listing: if not listing:
exit() sys.exit()
hours_len = len('Hours') hours_len = len('Hours')
pid_len = len('PID') pid_len = len('PID')

2
bin/swift-orphans
View File

@ -93,7 +93,7 @@ Example (sends SIGTERM to all orphaned Swift processes older than two hours):
listing.append((str(hours), pid, args)) listing.append((str(hours), pid, args))
if not listing: if not listing:
exit() sys.exit()
hours_len = len('Hours') hours_len = len('Hours')
pid_len = len('PID') pid_len = len('PID')