Merge "symlink: Ensure headers are returned as a list on py3" into stable/victoria

This commit is contained in:
Zuul 2021-05-26 04:38:13 +00:00 committed by Gerrit Code Review
commit 41335e63ff
2 changed files with 2 additions and 1 deletions

View File

@ -422,7 +422,7 @@ class SymlinkObjectContext(WSGIContext):
resp = self._app_call(req.environ) resp = self._app_call(req.environ)
response_header_dict = HeaderKeyDict(self._response_headers) response_header_dict = HeaderKeyDict(self._response_headers)
symlink_sysmeta_to_usermeta(response_header_dict) symlink_sysmeta_to_usermeta(response_header_dict)
self._response_headers = response_header_dict.items() self._response_headers = list(response_header_dict.items())
return resp return resp
def handle_get_head(self, req): def handle_get_head(self, req):

View File

@ -403,6 +403,7 @@ class TestSymlinkMiddleware(TestSymlinkMiddlewareBase):
req = Request.blank('/v1/a/c/symlink?symlink=get', method='GET') req = Request.blank('/v1/a/c/symlink?symlink=get', method='GET')
status, headers, body = self.call_sym(req) status, headers, body = self.call_sym(req)
self.assertEqual(status, '200 OK') self.assertEqual(status, '200 OK')
self.assertIsInstance(headers, list)
self.assertIn(('X-Symlink-Target', 'c1/o'), headers) self.assertIn(('X-Symlink-Target', 'c1/o'), headers)
self.assertNotIn('X-Symlink-Target-Account', dict(headers)) self.assertNotIn('X-Symlink-Target-Account', dict(headers))