openstack/swift
Code Issues Proposed changes

Remove utf-8 in metadata and http header names

Browse Source 
RFC2616 implicitly allows transferring utf-8 in
headers (vals) but not in header names (keys)

Swift functional tests includes testing for utf-8
header names (keys) which is non aligned with the standard.
This seem to be the case when testing file metadata.
File metadata keys are than transferred as part of
the http header keys (header names) as
      X-Object-Meta-<metadata_key>=metadata_name.

As a result metadata_keys in swift must be composed from
a subset of ASCII characters - alpha numerics,
some punctuation, not a lot else* and cannot be utf-8.

On branch bp/wsgi-application-interface-4
modified:   test/functional/tests.py

Change-Id: I1932e9d4ead83089e8a31a06d28a54f5625efb9c
Fixes: bug 1068026
Implements: blueprint wsgi-application-interface
This commit is contained in:
David Hadas
2012-10-23 09:48:24 +02:00
parent e2cb7a6855
commit 56e757257e
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/functional/tests.py
View File

@@ -868,7 +868,7 @@ class TestFile(Base):
metadata = {}
for i in range(1):
metadata[Utils.create_name()] = Utils.create_name()
metadata[Utils.create_ascii_name()] = Utils.create_name()
data = file.write_random()
file.sync_metadata(metadata)
@@ -954,7 +954,7 @@ class TestFile(Base):
metadata = {}
for i in range(1):
metadata[Utils.create_name()] = Utils.create_name()
metadata[Utils.create_ascii_name()] = Utils.create_name()
file.metadata = metadata
data = file.write_random()
@@ -1045,7 +1045,7 @@ class TestFile(Base):
self.assert_(file.delete())
self.assert_status(204)
file.metadata = {Utils.create_name(): Utils.create_name()}
file.metadata = {Utils.create_ascii_name(): Utils.create_name()}
for method in (file.info, file.read, file.sync_metadata,
file.delete):
@@ -1070,7 +1070,7 @@ class TestFile(Base):
size = 0
metadata = {}
while len(metadata.keys()) < i:
key = Utils.create_name()
key = Utils.create_ascii_name()
val = Utils.create_name()
if len(key) > j:
@@ -1323,7 +1323,7 @@ class TestFile(Base):
for i in range(10):
metadata = {}
for i in range(10):
metadata[Utils.create_name()] = Utils.create_name()
metadata[Utils.create_ascii_name()] = Utils.create_name()
file.metadata = metadata
self.assert_(file.sync_metadata())
@@ -1377,7 +1377,7 @@ class TestFile(Base):
for i in range(10):
metadata = {}
for j in range(10):
metadata[Utils.create_name()] = Utils.create_name()
metadata[Utils.create_ascii_name()] = Utils.create_name()
file = self.env.container.file(Utils.create_name())
file.metadata = metadata