openstack/swift
Code Issues Proposed changes

Minor refactor or broker empty() method

Browse Source 
to save db hits

Related-Change: I5b77e54c9ce2b6546feacbe856bf944a18f9b29d
Change-Id: I52a9dd1935d1e727712385cafe0cc38f77f4accb
This commit is contained in:
Alistair Coles 2018-04-17 08:30:24 +01:00
parent 5096862c22
commit 79f4f65888
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
swift/container/backend.py
View File

@ -669,8 +669,9 @@ class ContainerBroker(DatabaseBroker):
:returns: True if the database has no active objects, False otherwise
"""
return all([broker._empty() for broker in self.get_brokers()] +
[self.get_shard_usage()['object_count'] <= 0])
if not all(broker._empty() for broker in self.get_brokers()):
return False
return self.get_shard_usage()['object_count'] <= 0
def delete_object(self, name, timestamp, storage_policy_index=0):
"""