openstack/swift
Code Issues Proposed changes

mock out os.listdir to return a list

Browse Source 
os.listdir returns a list of items.  The test case had been
written to return a single item which, though not really changing
the result of the test, was not the best approach.

This patch updates the test case to return a list instead of a single
item.

Change-Id: I793e0636440c0de0ca339c6592adec3e8b4ee1b4
This commit is contained in:
Jay S. Bryant 2014-11-20 15:56:58 -06:00
parent d895cea07f
commit 8cc075a8fb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/unit/container/test_updater.py
View File

@ -180,7 +180,7 @@ class TestContainerUpdater(unittest.TestCase):
'permission_denied') 'permission_denied')
self.assertEqual(log_lines[0], msg) self.assertEqual(log_lines[0], msg)
@mock.patch('os.listdir', return_value='bar/') @mock.patch('os.listdir', return_value=['foo', 'bar'])
def test_listdir_without_exception(self, mock_listdir): def test_listdir_without_exception(self, mock_listdir):
cu = container_updater.ContainerUpdater({ cu = container_updater.ContainerUpdater({
'devices': self.devices_dir, 'devices': self.devices_dir,
@ -193,7 +193,7 @@ class TestContainerUpdater(unittest.TestCase):
}) })
cu.logger = FakeLogger() cu.logger = FakeLogger()
path = cu._listdir('foo/bar/') path = cu._listdir('foo/bar/')
self.assertEqual(path, 'bar/') self.assertEqual(path, ['foo', 'bar'])
log_lines = cu.logger.get_lines_for_level('error') log_lines = cu.logger.get_lines_for_level('error')
self.assertEqual(len(log_lines), 0) self.assertEqual(len(log_lines), 0)