openstack/swift
Code Issues Proposed changes

Stop clearing req.acl in DLO

Browse Source 
This has been pure misdirection since DLO was pulled out of the proxy
server; req.acl is always set by the object controller before calling
swift.authorize.

See TestDlo.test_dlo_referer_on_segment_container in
test/functional/test_dlo.py for proof that we still enforce segment
container ACLs properly.

Change-Id: I5321b5537787fcea126065243f1c4bd5e601181e
Related-Change: Ib3b3830c246816dd549fc74be98b4bc651e7bace
This commit is contained in:
Tim Burke
2017-08-31 23:36:38 +00:00
parent 9f5aa3bbd7
commit 8ed6e663d5
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
swift/common/middleware/dlo.py
View File

@@ -232,8 +232,6 @@ class GetContext(WSGIContext):
container = unquote(container) container = unquote(container)
obj_prefix = unquote(obj_prefix) obj_prefix = unquote(obj_prefix)
# manifest might point to a different container
req.acl = None
version, account, _junk = req.split_path(2, 3, True) version, account, _junk = req.split_path(2, 3, True)
error_response, segments = self._get_container_listing( error_response, segments = self._get_container_listing(
req, version, account, container, obj_prefix) req, version, account, container, obj_prefix)