openstack/swift
Code Issues Proposed changes

Turn on F812 check

Browse Source 
F812 list comprehension redefines <variable> from line ...

While the current violations were benign, this sort of code can easily
lead to subtle bugs. Seems worth checking, especially given how cheap it
is to bring existing code in line with it.

Change-Id: Ibdcf9f93b85a1f1411198001df6bdbfa8f92d114
This commit is contained in:
Tim Burke
2016-09-16 13:31:35 -07:00
parent acb8971c76
commit a741998bff
5 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bin/swift-account-audit
View File

@@ -266,7 +266,7 @@ class Auditor(object):
responses[node_id][1].extend(results)
if results:
marker = results[-1]['name']
headers = [resp[0] for resp in responses.values()]
headers = [r[0] for r in responses.values()]
cont_counts = [int(header['x-account-container-count'])
for header in headers]
if len(set(cont_counts)) != 1: