openstack/swift
Code Issues Proposed changes

docs: Clean up mount options

Browse Source 
* Stop specifying logbufs=8; that's the default
* Stop including nodiratime with noatime; the latter implies the former

Nothing wrong with being explicit, I suppose, but may as well keep the
mount options to what we can easily explain: we want noatime because
Swift does not use atime, so we don't want to lose any performance to
tracking atime.

Change-Id: I1e52b4368ad7eb375964eee5132bc50297536355
This commit is contained in:
Tim Burke 2020-05-03 00:42:09 -07:00
parent 207e08c64b
commit cb37d3acd6
8 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/deployment_guide.rst
View File

@ -2331,7 +2331,7 @@ headroom.
The following example mount options are recommended when using XFS::
mount -t xfs -o noatime,nodiratime,logbufs=8 -L D1 /srv/node/d1
mount -t xfs -o noatime -L D1 /srv/node/d1
We do not recommend running Swift on RAID, but if you are using
RAID it is also important to make sure that the proper sunit and swidth

12
doc/source/development_saio.rst
View File

@ -141,7 +141,7 @@ another device when creating the VM, and follow these instructions:
#. Edit ``/etc/fstab`` and add::
UUID="<UUID-from-output-above>" /mnt/sdb1 xfs noatime,nodiratime,logbufs=8 0 0
UUID="<UUID-from-output-above>" /mnt/sdb1 xfs noatime 0 0
#. Create the Swift data mount point and test that mounting works::
@ -169,7 +169,7 @@ these instructions:
#. Edit `/etc/fstab` and add::
/srv/swift-disk /mnt/sdb1 xfs loop,noatime,nodiratime,logbufs=8 0 0
/srv/swift-disk /mnt/sdb1 xfs loop,noatime 0 0
#. Create the Swift data mount point and test that mounting works::
@ -258,23 +258,23 @@ environment variable.
* To mount the tmp loopback device at ``/tmp``, do the following::
sudo mount -o loop,noatime,nodiratime /srv/swift-tmp /tmp
sudo mount -o loop,noatime /srv/swift-tmp /tmp
sudo chmod -R 1777 /tmp
* To persist this, edit and add the following to ``/etc/fstab``::
/srv/swift-tmp /tmp xfs rw,noatime,nodiratime,attr2,inode64,noquota 0 0
/srv/swift-tmp /tmp xfs rw,noatime,attr2,inode64,noquota 0 0
* To mount the tmp loopback at an alternate location (for example, ``/mnt/tmp``),
do the following::
sudo mkdir -p /mnt/tmp
sudo mount -o loop,noatime,nodiratime /srv/swift-tmp /mnt/tmp
sudo mount -o loop,noatime /srv/swift-tmp /mnt/tmp
sudo chown ${USER}:${USER} /mnt/tmp
* To persist this, edit and add the following to ``/etc/fstab``::
/srv/swift-tmp /mnt/tmp xfs rw,noatime,nodiratime,attr2,inode64,noquota 0 0
/srv/swift-tmp /mnt/tmp xfs rw,noatime,attr2,inode64,noquota 0 0
* Set your ``TMPDIR`` environment dir so that Swift looks in the right location::

4
doc/source/install/storage-install-obs.rst
View File

@ -59,8 +59,8 @@ storage nodes, you must prepare the storage devices.
.. code-block:: none
UUID="<UUID-from-output-above>" /srv/node/sdb xfs noatime,nodiratime,logbufs=8 0 2
UUID="<UUID-from-output-above>" /srv/node/sdc xfs noatime,nodiratime,logbufs=8 0 2
UUID="<UUID-from-output-above>" /srv/node/sdb xfs noatime 0 2
UUID="<UUID-from-output-above>" /srv/node/sdc xfs noatime 0 2
#. Mount the devices:

4
doc/source/install/storage-install-rdo.rst
View File

@ -58,8 +58,8 @@ storage nodes, you must prepare the storage devices.
.. code-block:: none
UUID="<UUID-from-output-above>" /srv/node/sdb xfs noatime,nodiratime,logbufs=8 0 2
UUID="<UUID-from-output-above>" /srv/node/sdc xfs noatime,nodiratime,logbufs=8 0 2
UUID="<UUID-from-output-above>" /srv/node/sdb xfs noatime 0 2
UUID="<UUID-from-output-above>" /srv/node/sdc xfs noatime 0 2
#. Mount the devices:

4
doc/source/install/storage-install-ubuntu-debian.rst
View File

@ -58,8 +58,8 @@ storage nodes, you must prepare the storage devices.
.. code-block:: none
UUID="<UUID-from-output-above>" /srv/node/sdb xfs noatime,nodiratime,logbufs=8 0 2
UUID="<UUID-from-output-above>" /srv/node/sdc xfs noatime,nodiratime,logbufs=8 0 2
UUID="<UUID-from-output-above>" /srv/node/sdb xfs noatime 0 2
UUID="<UUID-from-output-above>" /srv/node/sdc xfs noatime 0 2
#. Mount the devices:

2
docker/rootfs/etc/swift_build/build_devices
View File

@ -56,7 +56,7 @@ if [[ $MY_STORAGE_TYPE == "internal_devices" ]] || [[ $MY_STORAGE_TYPE == "exter
# echo "created storage device /dev/swift-d$i of $DEV_SIZE";
mkfs.xfs -f -L D$i -i size=512 /dev/$device;
echo " created XFS file system on device /dev/$device";
mount -t xfs -o noatime,nodiratime,logbufs=8 /dev/$device /srv/node/$device;
mount -t xfs -o noatime /dev/$device /srv/node/$device;
echo " mounted /dev/$device as /srv/node/$device";
done
fi

2
tools/playbooks/multinode_setup/configure_loopback.yaml
View File

@ -31,7 +31,7 @@
state: directory
- name: mount /mnt/sdb1
mount: name=/mnt/sdb1 src=/srv/swift-disk fstype=xfs opts="loop,noatime,nodiratime,logbufs=8" dump=0 passno=0 state=mounted
mount: name=/mnt/sdb1 src=/srv/swift-disk fstype=xfs opts="loop,noatime" dump=0 passno=0 state=mounted
- name: create sub-partitions
file:

2
tools/playbooks/saio_single_node_setup/setup_saio.yaml
View File

@ -29,7 +29,7 @@
file: path=/mnt/sdb1 state=directory
- name: mount /mnt/sdb1
mount: name=/mnt/sdb1 src=/srv/swift-disk fstype=xfs opts="loop,noatime,nodiratime,logbufs=8" dump=0 passno=0 state=mounted
mount: name=/mnt/sdb1 src=/srv/swift-disk fstype=xfs opts="loop,noatime" dump=0 passno=0 state=mounted
- name: create sub-partitions
file: >