openstack/swift
Code Issues Proposed changes

trivial: assert non_negative_int treats float as valid

Browse Source 
Prior to the Related-Change, non_negative_int would raise a ValueError
if it was passed a positive float. It now casts the float to an int,
which is consistent with the docstring.

This patch adds test assertions to verify this behavior, and similar
behavior of config_positive_int_value.

Change-Id: I5d62e14c228544af634190f16321ee97a8c4211c
Related-Change: I06508279d59fa57296dd85548f271a7812aeb45f
This commit is contained in:
Alistair Coles 2024-07-17 10:14:24 +01:00
parent 7c12870068
commit e984de864d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/unit/common/utils/test_config.py
View File

@ -77,6 +77,7 @@ class TestUtilsConfig(unittest.TestCase):
self.assertEqual(0, config.non_negative_int('0'))
self.assertEqual(0, config.non_negative_int(0.0))
self.assertEqual(1, config.non_negative_int(1))
self.assertEqual(1, config.non_negative_int(1.1))
self.assertEqual(1, config.non_negative_int('1'))
self.assertEqual(1, config.non_negative_int(True))
self.assertEqual(0, config.non_negative_int(False))
@ -118,6 +119,7 @@ class TestUtilsConfig(unittest.TestCase):
u'1': 1,
b'1': 1,
1: 1,
1.1: 1,
u'2': 2,
b'2': 2,
u'1024': 1024,