XFS no longer supports nobarrier mount option.
It has been deprecated for a long time[1] and removed in
recent kernel versions resulting in an error when trying to
mount: "kernel: XFS (loop0): unknown mount option [nobarrier]."
[1] - https://patchwork.kernel.org/patch/9486549/
Change-Id: Iaa9208fb20545ae9ac990f0e180899108d983123
On py3, if/when you hit an error, you can get very noisy tracebacks like
<traceback coming out of split_path()>
During handling of the above exception, another exception occurred:
<meaningful traceback>
In general, I like this, but when we've used exception handling for
flow-control, it gets difficult to separate the wheat from the chaff.
Change-Id: I5f3bc6416207cab2c7e3a77ee6689360b55990e7
0.25.0 is now included in upper-constraints.txt
Related-Change: I04be480829eaf67ce328b2e7f7d7e2f70aaed90e
Change-Id: I5b8ecd82d6915d0e1cb216c423bbcc75c50a6f3d
Query strings and upload IDs should be native strings.
With this, you should be able to run the s3api functional tests under
py2 against py3 services.
Change-Id: I896c84872a5d63b23d6edabeb6d48ce7bc9a533e
Previously, we stored the WSGI strings in memcached and returned them when
responding to get_account/container_info calls. This would lead to cache
corruption in a heterogenous py2/py3 cluster such as you would have during
a rolling upgrade.
Now, only store and return native strings.
Change-Id: I8d6f66dfe846493972e433f70bad76a33d204562
His company changes the e-mail domain and the old one has been
recieve-only so to update the author's e-mail address, add the
entry to the mailmap.
Change-Id: I0c1f77425d9cefb2e6340ffb4c65cdea956c216f
- Use `set -e` in all install scripts. Clean up swift_needs to still
work properly and exit cleanly under `set -e`.
- Drop some redundant slashes.
Change-Id: I05f38c6366e3da0aeed2b6451a8bd9d7dc531119
This patch increases the test coverage of the following middlewares:
- list_endpoints
- crypto
- crossdomain
Change-Id: I3dec85f61da07bd110bf42220d5ba46e11833a90
This precludes us from landing anything in the gate, because we
treat Sphinx warnings as errors in OpenStack.
Specifically, 3 warnings are fixed:
/home/zuul/src/opendev.org/openstack/swift/swift/common/middleware\
/s3api/etree.py:docstring of\
swift.common.middleware.s3api.etree.Element:1:\
Inline strong start-string without end-string.
duplicate object description of\
swift.common.middleware.versioned_writes, other instance in\
middleware, use :noindex: for one of them
duplicate object description of\
swift.common.ring.composite_builder, other instance in\
overview_ring, use :noindex: for one of them
Change-Id: I5e0bd61a301d46b2674b4605882462575b635220
The commit a0fcca1e makes reconstructor not sync suffixes when remote
reject reconstructor revert. However, the exact same logic should
be applied to SYNC job as well. REPLICATE requests aren't generally
needed when using SSYC (which the reconstructor always does).
If a ssync_sender fails to finish a sync the reconstructor should skip
the REPLICATE call entirely and move on to the next partition without
causing any useless remote IO.
Change-Id: Ida50539e645ea7e2950ba668c7f031a8d10da787
Closes-Bug: #1665141
If the data in a hashes.pkl is corrupted but still de-serialized without
errors, it will mess up the replication and gets never fixed. This
happens for example if one of the keys is a NULL byte.
This patch checks if the dict keys in hashes.pkl are valid strings and
invalidates it if not.
Closes-Bug: 1830881
Change-Id: I84b062d062ff49935feed0aee3e1963bb72eb5ea
This patch ports the symlink middleware to py3.
The middleware itself seems to be mostly fine and most changes
are in the symlink unit tests.
Change-Id: I973c2e1bb8969cf6bffece8ce68881c393efbaef