728b4ba140
Currently, our integrity checking for objects is pretty weak when it comes to object metadata. If the extended attributes on a .data or .meta file get corrupted in such a way that we can still unpickle it, we don't have anything that detects that. This could be especially bad with encrypted etags; if the encrypted etag (X-Object-Sysmeta-Crypto-Etag or whatever it is) gets some bits flipped, then we'll cheerfully decrypt the cipherjunk into plainjunk, then send it to the client. Net effect is that the client sees a GET response with an ETag that doesn't match the MD5 of the object *and* Swift has no way of detecting and quarantining this object. Note that, with an unencrypted object, if the ETag metadatum gets mangled, then the object will be quarantined by the object server or auditor, whichever notices first. As part of this commit, I also ripped out some mocking of getxattr/setxattr in tests. It appears to be there to allow unit tests to run on systems where /tmp doesn't support xattrs. However, since the mock is keyed off of inode number and inode numbers get re-used, there's lots of leakage between different test runs. On a real FS, unlinking a file and then creating a new one of the same name will also reset the xattrs; this isn't the case with the mock. The mock was pretty old; Ubuntu 12.04 and up all support xattrs in /tmp, and recent Red Hat / CentOS releases do too. The xattr mock was added in 2011; maybe it was to support Ubuntu Lucid Lynx? Bonus: now you can pause a test with the debugger, inspect its files in /tmp, and actually see the xattrs along with the data. Since this patch now uses a real filesystem for testing filesystem operations, tests are skipped if the underlying filesystem does not support setting xattrs (eg tmpfs or more than 4k of xattrs on ext4). References to "/tmp" have been replaced with calls to tempfile.gettempdir(). This will allow setting the TMPDIR envvar in test setup and getting an XFS filesystem instead of ext4 or tmpfs. THIS PATCH SIGNIFICANTLY CHANGES TESTING ENVIRONMENTS With this patch, every test environment will require TMPDIR to be using a filesystem that supports at least 4k of extended attributes. Neither ext4 nor tempfs support this. XFS is recommended. So why all the SkipTests? Why not simply raise an error? We still need the tests to run on the base image for OpenStack's CI system. Since we were previously mocking out xattr, there wasn't a problem, but we also weren't actually testing anything. This patch adds functionality to validate xattr data, so we need to drop the mock. `test.unit.skip_if_no_xattrs()` is also imported into `test.functional` so that functional tests can import it from the functional test namespace. The related OpenStack CI infrastructure changes are made in https://review.openstack.org/#/c/394600/. Co-Authored-By: John Dickinson <me@not.mn> Change-Id: I98a37c0d451f4960b7a12f648e4405c6c6716808
913 lines
34 KiB
Python
913 lines
34 KiB
Python
#!/usr/bin/python
|
|
|
|
# Copyright (c) 2010-2012 OpenStack Foundation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import unittest2
|
|
import json
|
|
from uuid import uuid4
|
|
from unittest2 import SkipTest
|
|
from string import ascii_letters
|
|
|
|
from six.moves import range
|
|
from swift.common.middleware.acl import format_acl
|
|
|
|
from test.functional import check_response, retry, requires_acls, \
|
|
load_constraint
|
|
import test.functional as tf
|
|
|
|
|
|
def setUpModule():
|
|
tf.setup_package()
|
|
|
|
|
|
def tearDownModule():
|
|
tf.teardown_package()
|
|
|
|
|
|
class TestAccount(unittest2.TestCase):
|
|
existing_metadata = None
|
|
|
|
@classmethod
|
|
def get_meta(cls):
|
|
def head(url, token, parsed, conn):
|
|
conn.request('HEAD', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
resp = retry(head)
|
|
resp.read()
|
|
return dict((k, v) for k, v in resp.getheaders() if
|
|
k.lower().startswith('x-account-meta'))
|
|
|
|
@classmethod
|
|
def clear_meta(cls, remove_metadata_keys):
|
|
def post(url, token, parsed, conn, hdr_keys):
|
|
headers = {'X-Auth-Token': token}
|
|
headers.update((k, '') for k in hdr_keys)
|
|
conn.request('POST', parsed.path, '', headers)
|
|
return check_response(conn)
|
|
|
|
for i in range(0, len(remove_metadata_keys), 90):
|
|
batch = remove_metadata_keys[i:i + 90]
|
|
resp = retry(post, batch)
|
|
resp.read()
|
|
|
|
@classmethod
|
|
def set_meta(cls, metadata):
|
|
def post(url, token, parsed, conn, meta_hdrs):
|
|
headers = {'X-Auth-Token': token}
|
|
headers.update(meta_hdrs)
|
|
conn.request('POST', parsed.path, '', headers)
|
|
return check_response(conn)
|
|
|
|
if not metadata:
|
|
return
|
|
resp = retry(post, metadata)
|
|
resp.read()
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
# remove and stash any existing account user metadata before tests
|
|
cls.existing_metadata = cls.get_meta()
|
|
cls.clear_meta(cls.existing_metadata.keys())
|
|
|
|
@classmethod
|
|
def tearDownClass(cls):
|
|
# replace any stashed account user metadata
|
|
cls.set_meta(cls.existing_metadata)
|
|
|
|
def setUp(self):
|
|
self.max_meta_count = load_constraint('max_meta_count')
|
|
self.max_meta_name_length = load_constraint('max_meta_name_length')
|
|
self.max_meta_overall_size = load_constraint('max_meta_overall_size')
|
|
self.max_meta_value_length = load_constraint('max_meta_value_length')
|
|
|
|
def tearDown(self):
|
|
# clean up any account user metadata created by test
|
|
new_metadata = self.get_meta().keys()
|
|
self.clear_meta(new_metadata)
|
|
|
|
def test_metadata(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, value):
|
|
conn.request('POST', parsed.path, '',
|
|
{'X-Auth-Token': token, 'X-Account-Meta-Test': value})
|
|
return check_response(conn)
|
|
|
|
def head(url, token, parsed, conn):
|
|
conn.request('HEAD', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
def get(url, token, parsed, conn):
|
|
conn.request('GET', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
resp = retry(post, '')
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(head)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertIsNone(resp.getheader('x-account-meta-test'))
|
|
resp = retry(get)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertIsNone(resp.getheader('x-account-meta-test'))
|
|
resp = retry(post, 'Value')
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(head)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader('x-account-meta-test'), 'Value')
|
|
resp = retry(get)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader('x-account-meta-test'), 'Value')
|
|
|
|
def test_invalid_acls(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
# needs to be an acceptable header size
|
|
num_keys = 8
|
|
max_key_size = load_constraint('max_header_size') / num_keys
|
|
acl = {'admin': [c * max_key_size for c in ascii_letters[:num_keys]]}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
|
|
# and again a touch smaller
|
|
acl = {'admin': [c * max_key_size for c
|
|
in ascii_letters[:num_keys - 1]]}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
@requires_acls
|
|
def test_invalid_acl_keys(self):
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
# needs to be json
|
|
resp = retry(post, headers={'X-Account-Access-Control': 'invalid'},
|
|
use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
|
|
acl_user = tf.swift_test_user[1]
|
|
acl = {'admin': [acl_user], 'invalid_key': 'invalid_value'}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
|
|
resp = retry(post, headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
@requires_acls
|
|
def test_invalid_acl_values(self):
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
acl = {'admin': 'invalid_value'}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
@requires_acls
|
|
def test_read_only_acl(self):
|
|
if tf.skip3:
|
|
raise SkipTest
|
|
|
|
def get(url, token, parsed, conn):
|
|
conn.request('GET', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
# cannot read account
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 403)
|
|
|
|
# grant read access
|
|
acl_user = tf.swift_test_user[2]
|
|
acl = {'read-only': [acl_user]}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# read-only can read account headers
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
# but not acls
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
# read-only can not write metadata
|
|
headers = {'x-account-meta-test': 'value'}
|
|
resp = retry(post, headers=headers, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 403)
|
|
|
|
# but they can read it
|
|
headers = {'x-account-meta-test': 'value'}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader('X-Account-Meta-Test'), 'value')
|
|
|
|
@requires_acls
|
|
def test_read_write_acl(self):
|
|
if tf.skip3:
|
|
raise SkipTest
|
|
|
|
def get(url, token, parsed, conn):
|
|
conn.request('GET', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
# cannot read account
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 403)
|
|
|
|
# grant read-write access
|
|
acl_user = tf.swift_test_user[2]
|
|
acl = {'read-write': [acl_user]}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# read-write can read account headers
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
# but not acls
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
# read-write can not write account metadata
|
|
headers = {'x-account-meta-test': 'value'}
|
|
resp = retry(post, headers=headers, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 403)
|
|
|
|
@requires_acls
|
|
def test_admin_acl(self):
|
|
if tf.skip3:
|
|
raise SkipTest
|
|
|
|
def get(url, token, parsed, conn):
|
|
conn.request('GET', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
# cannot read account
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 403)
|
|
|
|
# grant admin access
|
|
acl_user = tf.swift_test_user[2]
|
|
acl = {'admin': [acl_user]}
|
|
acl_json_str = format_acl(version=2, acl_dict=acl)
|
|
headers = {'x-account-access-control': acl_json_str}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# admin can read account headers
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
# including acls
|
|
self.assertEqual(resp.getheader('X-Account-Access-Control'),
|
|
acl_json_str)
|
|
|
|
# admin can write account metadata
|
|
value = str(uuid4())
|
|
headers = {'x-account-meta-test': value}
|
|
resp = retry(post, headers=headers, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader('X-Account-Meta-Test'), value)
|
|
|
|
# admin can even revoke their own access
|
|
headers = {'x-account-access-control': '{}'}
|
|
resp = retry(post, headers=headers, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# and again, cannot read account
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 403)
|
|
|
|
@requires_acls
|
|
def test_protected_tempurl(self):
|
|
if tf.skip3:
|
|
raise SkipTest
|
|
|
|
def get(url, token, parsed, conn):
|
|
conn.request('GET', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
# add an account metadata, and temp-url-key to account
|
|
value = str(uuid4())
|
|
headers = {
|
|
'x-account-meta-temp-url-key': 'secret',
|
|
'x-account-meta-test': value,
|
|
}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# grant read-only access to tester3
|
|
acl_user = tf.swift_test_user[2]
|
|
acl = {'read-only': [acl_user]}
|
|
acl_json_str = format_acl(version=2, acl_dict=acl)
|
|
headers = {'x-account-access-control': acl_json_str}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# read-only tester3 can read account metadata
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204),
|
|
'Expected status in (200, 204), got %s' % resp.status)
|
|
self.assertEqual(resp.getheader('X-Account-Meta-Test'), value)
|
|
# but not temp-url-key
|
|
self.assertIsNone(resp.getheader('X-Account-Meta-Temp-Url-Key'))
|
|
|
|
# grant read-write access to tester3
|
|
acl_user = tf.swift_test_user[2]
|
|
acl = {'read-write': [acl_user]}
|
|
acl_json_str = format_acl(version=2, acl_dict=acl)
|
|
headers = {'x-account-access-control': acl_json_str}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# read-write tester3 can read account metadata
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204),
|
|
'Expected status in (200, 204), got %s' % resp.status)
|
|
self.assertEqual(resp.getheader('X-Account-Meta-Test'), value)
|
|
# but not temp-url-key
|
|
self.assertIsNone(resp.getheader('X-Account-Meta-Temp-Url-Key'))
|
|
|
|
# grant admin access to tester3
|
|
acl_user = tf.swift_test_user[2]
|
|
acl = {'admin': [acl_user]}
|
|
acl_json_str = format_acl(version=2, acl_dict=acl)
|
|
headers = {'x-account-access-control': acl_json_str}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# admin tester3 can read account metadata
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204),
|
|
'Expected status in (200, 204), got %s' % resp.status)
|
|
self.assertEqual(resp.getheader('X-Account-Meta-Test'), value)
|
|
# including temp-url-key
|
|
self.assertEqual(resp.getheader('X-Account-Meta-Temp-Url-Key'),
|
|
'secret')
|
|
|
|
# admin tester3 can even change temp-url-key
|
|
secret = str(uuid4())
|
|
headers = {
|
|
'x-account-meta-temp-url-key': secret,
|
|
}
|
|
resp = retry(post, headers=headers, use_account=3)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(get, use_account=3)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204),
|
|
'Expected status in (200, 204), got %s' % resp.status)
|
|
self.assertEqual(resp.getheader('X-Account-Meta-Temp-Url-Key'),
|
|
secret)
|
|
|
|
@requires_acls
|
|
def test_account_acls(self):
|
|
if tf.skip2:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
def put(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('PUT', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
def delete(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('DELETE', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
def head(url, token, parsed, conn):
|
|
conn.request('HEAD', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
def get(url, token, parsed, conn):
|
|
conn.request('GET', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
try:
|
|
# User1 can POST to their own account (and reset the ACLs)
|
|
resp = retry(post, headers={'X-Account-Access-Control': '{}'},
|
|
use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
# User1 can GET their own empty account
|
|
resp = retry(get, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status // 100, 2)
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
# User2 can't GET User1's account
|
|
resp = retry(get, use_account=2, url_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 403)
|
|
|
|
# User1 is swift_owner of their own account, so they can POST an
|
|
# ACL -- let's do this and make User2 (test_user[1]) an admin
|
|
acl_user = tf.swift_test_user[1]
|
|
acl = {'admin': [acl_user]}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# User1 can see the new header
|
|
resp = retry(get, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status // 100, 2)
|
|
data_from_headers = resp.getheader('x-account-access-control')
|
|
expected = json.dumps(acl, separators=(',', ':'))
|
|
self.assertEqual(data_from_headers, expected)
|
|
|
|
# Now User2 should be able to GET the account and see the ACL
|
|
resp = retry(head, use_account=2, url_account=1)
|
|
resp.read()
|
|
data_from_headers = resp.getheader('x-account-access-control')
|
|
self.assertEqual(data_from_headers, expected)
|
|
|
|
# Revoke User2's admin access, grant User2 read-write access
|
|
acl = {'read-write': [acl_user]}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# User2 can still GET the account, but not see the ACL
|
|
# (since it's privileged data)
|
|
resp = retry(head, use_account=2, url_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
self.assertIsNone(resp.getheader('x-account-access-control'))
|
|
|
|
# User2 can PUT and DELETE a container
|
|
resp = retry(put, use_account=2, url_account=1,
|
|
resource='%(storage_url)s/mycontainer', headers={})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 201)
|
|
resp = retry(delete, use_account=2, url_account=1,
|
|
resource='%(storage_url)s/mycontainer', headers={})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# Revoke User2's read-write access, grant User2 read-only access
|
|
acl = {'read-only': [acl_user]}
|
|
headers = {'x-account-access-control': format_acl(
|
|
version=2, acl_dict=acl)}
|
|
resp = retry(post, headers=headers, use_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# User2 can still GET the account, but not see the ACL
|
|
# (since it's privileged data)
|
|
resp = retry(head, use_account=2, url_account=1)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
self.assertIsNone(resp.getheader('x-account-access-control'))
|
|
|
|
# User2 can't PUT a container
|
|
resp = retry(put, use_account=2, url_account=1,
|
|
resource='%(storage_url)s/mycontainer', headers={})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 403)
|
|
|
|
finally:
|
|
# Make sure to clean up even if tests fail -- User2 should not
|
|
# have access to User1's account in other functional tests!
|
|
resp = retry(post, headers={'X-Account-Access-Control': '{}'},
|
|
use_account=1)
|
|
resp.read()
|
|
|
|
@requires_acls
|
|
def test_swift_account_acls(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
def head(url, token, parsed, conn):
|
|
conn.request('HEAD', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
def get(url, token, parsed, conn):
|
|
conn.request('GET', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
try:
|
|
# User1 can POST to their own account
|
|
resp = retry(post, headers={'X-Account-Access-Control': '{}'})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
# User1 can GET their own empty account
|
|
resp = retry(get)
|
|
resp.read()
|
|
self.assertEqual(resp.status // 100, 2)
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
# User1 can POST non-empty data
|
|
acl_json = '{"admin":["bob"]}'
|
|
resp = retry(post, headers={'X-Account-Access-Control': acl_json})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# User1 can GET the non-empty data
|
|
resp = retry(get)
|
|
resp.read()
|
|
self.assertEqual(resp.status // 100, 2)
|
|
self.assertEqual(resp.getheader('X-Account-Access-Control'),
|
|
acl_json)
|
|
|
|
# POST non-JSON ACL should fail
|
|
resp = retry(post, headers={'X-Account-Access-Control': 'yuck'})
|
|
resp.read()
|
|
# resp.status will be 400 if tempauth or some other ACL-aware
|
|
# auth middleware rejects it, or 200 (but silently swallowed by
|
|
# core Swift) if ACL-unaware auth middleware approves it.
|
|
|
|
# A subsequent GET should show the old, valid data, not the garbage
|
|
resp = retry(get)
|
|
resp.read()
|
|
self.assertEqual(resp.status // 100, 2)
|
|
self.assertEqual(resp.getheader('X-Account-Access-Control'),
|
|
acl_json)
|
|
|
|
finally:
|
|
# Make sure to clean up even if tests fail -- User2 should not
|
|
# have access to User1's account in other functional tests!
|
|
resp = retry(post, headers={'X-Account-Access-Control': '{}'})
|
|
resp.read()
|
|
|
|
def test_swift_prohibits_garbage_account_acls(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, headers):
|
|
new_headers = dict({'X-Auth-Token': token}, **headers)
|
|
conn.request('POST', parsed.path, '', new_headers)
|
|
return check_response(conn)
|
|
|
|
def get(url, token, parsed, conn):
|
|
conn.request('GET', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
try:
|
|
# User1 can POST to their own account
|
|
resp = retry(post, headers={'X-Account-Access-Control': '{}'})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
# User1 can GET their own empty account
|
|
resp = retry(get)
|
|
resp.read()
|
|
self.assertEqual(resp.status // 100, 2)
|
|
self.assertIsNone(resp.getheader('X-Account-Access-Control'))
|
|
|
|
# User1 can POST non-empty data
|
|
acl_json = '{"admin":["bob"]}'
|
|
resp = retry(post, headers={'X-Account-Access-Control': acl_json})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
# If this request is handled by ACL-aware auth middleware, then the
|
|
# ACL will be persisted. If it is handled by ACL-unaware auth
|
|
# middleware, then the header will be thrown out. But the request
|
|
# should return successfully in any case.
|
|
|
|
# User1 can GET the non-empty data
|
|
resp = retry(get)
|
|
resp.read()
|
|
self.assertEqual(resp.status // 100, 2)
|
|
# ACL will be set if some ACL-aware auth middleware (e.g. tempauth)
|
|
# propagates it to sysmeta; if no ACL-aware auth middleware does,
|
|
# then X-Account-Access-Control will still be empty.
|
|
|
|
# POST non-JSON ACL should fail
|
|
resp = retry(post, headers={'X-Account-Access-Control': 'yuck'})
|
|
resp.read()
|
|
# resp.status will be 400 if tempauth or some other ACL-aware
|
|
# auth middleware rejects it, or 200 (but silently swallowed by
|
|
# core Swift) if ACL-unaware auth middleware approves it.
|
|
|
|
# A subsequent GET should either show the old, valid data (if
|
|
# ACL-aware auth middleware is propagating it) or show nothing
|
|
# (if no auth middleware in the pipeline is ACL-aware), but should
|
|
# never return the garbage ACL.
|
|
resp = retry(get)
|
|
resp.read()
|
|
self.assertEqual(resp.status // 100, 2)
|
|
self.assertNotEqual(resp.getheader('X-Account-Access-Control'),
|
|
'yuck')
|
|
|
|
finally:
|
|
# Make sure to clean up even if tests fail -- User2 should not
|
|
# have access to User1's account in other functional tests!
|
|
resp = retry(post, headers={'X-Account-Access-Control': '{}'})
|
|
resp.read()
|
|
|
|
def test_unicode_metadata(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, name, value):
|
|
conn.request('POST', parsed.path, '',
|
|
{'X-Auth-Token': token, name: value})
|
|
return check_response(conn)
|
|
|
|
def head(url, token, parsed, conn):
|
|
conn.request('HEAD', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
uni_key = u'X-Account-Meta-uni\u0E12'
|
|
uni_value = u'uni\u0E12'
|
|
if (tf.web_front_end == 'integral'):
|
|
resp = retry(post, uni_key, '1')
|
|
resp.read()
|
|
self.assertIn(resp.status, (201, 204))
|
|
resp = retry(head)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader(uni_key.encode('utf-8')), '1')
|
|
resp = retry(post, 'X-Account-Meta-uni', uni_value)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(head)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader('X-Account-Meta-uni'),
|
|
uni_value.encode('utf-8'))
|
|
if (tf.web_front_end == 'integral'):
|
|
resp = retry(post, uni_key, uni_value)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(head)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader(uni_key.encode('utf-8')),
|
|
uni_value.encode('utf-8'))
|
|
|
|
def test_multi_metadata(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, name, value):
|
|
conn.request('POST', parsed.path, '',
|
|
{'X-Auth-Token': token, name: value})
|
|
return check_response(conn)
|
|
|
|
def head(url, token, parsed, conn):
|
|
conn.request('HEAD', parsed.path, '', {'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
resp = retry(post, 'X-Account-Meta-One', '1')
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(head)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader('x-account-meta-one'), '1')
|
|
resp = retry(post, 'X-Account-Meta-Two', '2')
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(head)
|
|
resp.read()
|
|
self.assertIn(resp.status, (200, 204))
|
|
self.assertEqual(resp.getheader('x-account-meta-one'), '1')
|
|
self.assertEqual(resp.getheader('x-account-meta-two'), '2')
|
|
|
|
def test_bad_metadata(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, extra_headers):
|
|
headers = {'X-Auth-Token': token}
|
|
headers.update(extra_headers)
|
|
conn.request('POST', parsed.path, '', headers)
|
|
return check_response(conn)
|
|
|
|
resp = retry(post,
|
|
{'X-Account-Meta-' + (
|
|
'k' * self.max_meta_name_length): 'v'})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(
|
|
post,
|
|
{'X-Account-Meta-' + ('k' * (
|
|
self.max_meta_name_length + 1)): 'v'})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
|
|
resp = retry(post,
|
|
{'X-Account-Meta-Too-Long': (
|
|
'k' * self.max_meta_value_length)})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
resp = retry(
|
|
post,
|
|
{'X-Account-Meta-Too-Long': 'k' * (
|
|
self.max_meta_value_length + 1)})
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
|
|
def test_bad_metadata2(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
def post(url, token, parsed, conn, extra_headers):
|
|
headers = {'X-Auth-Token': token}
|
|
headers.update(extra_headers)
|
|
conn.request('POST', parsed.path, '', headers)
|
|
return check_response(conn)
|
|
|
|
headers = {}
|
|
for x in range(self.max_meta_count):
|
|
headers['X-Account-Meta-%d' % x] = 'v'
|
|
resp = retry(post, headers)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
headers = {}
|
|
for x in range(self.max_meta_count + 1):
|
|
headers['X-Account-Meta-%d' % x] = 'v'
|
|
resp = retry(post, headers)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
|
|
def test_bad_metadata3(self):
|
|
if tf.skip:
|
|
raise SkipTest
|
|
|
|
if tf.in_process:
|
|
tf.skip_if_no_xattrs()
|
|
|
|
def post(url, token, parsed, conn, extra_headers):
|
|
headers = {'X-Auth-Token': token}
|
|
headers.update(extra_headers)
|
|
conn.request('POST', parsed.path, '', headers)
|
|
return check_response(conn)
|
|
|
|
headers = {}
|
|
header_value = 'k' * self.max_meta_value_length
|
|
size = 0
|
|
x = 0
|
|
while size < (self.max_meta_overall_size - 4
|
|
- self.max_meta_value_length):
|
|
size += 4 + self.max_meta_value_length
|
|
headers['X-Account-Meta-%04d' % x] = header_value
|
|
x += 1
|
|
if self.max_meta_overall_size - size > 1:
|
|
headers['X-Account-Meta-k'] = \
|
|
'v' * (self.max_meta_overall_size - size - 1)
|
|
resp = retry(post, headers)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
# this POST includes metadata size that is over limit
|
|
headers['X-Account-Meta-k'] = \
|
|
'x' * (self.max_meta_overall_size - size)
|
|
resp = retry(post, headers)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
# this POST would be ok and the aggregate backend metadata
|
|
# size is on the border
|
|
headers = {'X-Account-Meta-k':
|
|
'y' * (self.max_meta_overall_size - size - 1)}
|
|
resp = retry(post, headers)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
# this last POST would be ok by itself but takes the aggregate
|
|
# backend metadata size over limit
|
|
headers = {'X-Account-Meta-k':
|
|
'z' * (self.max_meta_overall_size - size)}
|
|
resp = retry(post, headers)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 400)
|
|
|
|
|
|
class TestAccountInNonDefaultDomain(unittest2.TestCase):
|
|
def setUp(self):
|
|
if tf.skip or tf.skip2 or tf.skip_if_not_v3:
|
|
raise SkipTest('AUTH VERSION 3 SPECIFIC TEST')
|
|
|
|
def test_project_domain_id_header(self):
|
|
# make sure account exists (assumes account auto create)
|
|
def post(url, token, parsed, conn):
|
|
conn.request('POST', parsed.path, '',
|
|
{'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
resp = retry(post, use_account=4)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
|
|
# account in non-default domain should have a project domain id
|
|
def head(url, token, parsed, conn):
|
|
conn.request('HEAD', parsed.path, '',
|
|
{'X-Auth-Token': token})
|
|
return check_response(conn)
|
|
|
|
resp = retry(head, use_account=4)
|
|
resp.read()
|
|
self.assertEqual(resp.status, 204)
|
|
self.assertIn('X-Account-Project-Domain-Id', resp.headers)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest2.main()
|