0e81ffd1e1
Consider a client that's downloading a large replicated object of size N bytes. If the object server process dies (e.g. with a segfault) partway through the download, the proxy will have read fewer than N bytes, and then read(sockfd) will start returning 0 bytes. At this point, the proxy believes the object download is complete, and so the WSGI server waits for a new request to come in. Meanwhile, the client is waiting for the rest of their bytes. Until the client times out, that socket will be held open. The fix is to look at the Content-Length and Content-Range headers in the response from the object server, then retry with another object server in case the original GET is truncated. This way, the client gets all the bytes they should. Note that ResumingGetter already had retry logic for when an object-server is slow to send bytes -- this extends it to also cover unexpected disconnects. Change-Id: Iab1e07706193ddc86832fd2cff0d7c2cb6d79ad9 Related-Change: I74d8c13eba2a4917b5a116875b51a781b33a7abf Closes-Bug: 1568650
85 lines
1.9 KiB
Python
85 lines
1.9 KiB
Python
# Copyright (c) 2010-2013 OpenStack, LLC.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import unittest
|
|
|
|
from test.unit.proxy import test_server
|
|
|
|
from swift.obj import mem_server
|
|
|
|
|
|
def setUpModule():
|
|
test_server.do_setup(mem_server)
|
|
|
|
|
|
def tearDownModule():
|
|
test_server.tearDownModule()
|
|
|
|
|
|
class TestController(test_server.TestController):
|
|
pass
|
|
|
|
|
|
class TestProxyServer(test_server.TestProxyServer):
|
|
pass
|
|
|
|
|
|
class TestReplicatedObjectController(
|
|
test_server.TestReplicatedObjectController):
|
|
def test_PUT_no_etag_fallocate(self):
|
|
# mem server doesn't call fallocate(), believe it or not
|
|
pass
|
|
|
|
# these tests all go looking in the filesystem
|
|
def test_policy_IO(self):
|
|
pass
|
|
|
|
def test_GET_short_read(self):
|
|
pass
|
|
|
|
def test_GET_short_read_resuming(self):
|
|
pass
|
|
|
|
|
|
class TestECObjectController(test_server.TestECObjectController):
|
|
def test_PUT_ec(self):
|
|
pass
|
|
|
|
def test_PUT_ec_multiple_segments(self):
|
|
pass
|
|
|
|
def test_PUT_ec_fragment_archive_etag_mismatch(self):
|
|
pass
|
|
|
|
def test_reload_ring_ec(self):
|
|
pass
|
|
|
|
|
|
class TestContainerController(test_server.TestContainerController):
|
|
pass
|
|
|
|
|
|
class TestAccountController(test_server.TestAccountController):
|
|
pass
|
|
|
|
|
|
class TestAccountControllerFakeGetResponse(
|
|
test_server.TestAccountControllerFakeGetResponse):
|
|
pass
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|