openstack
/
tacker
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(1 comment)

Patch-set: 6
This commit is contained in:
Gerrit User 8556 2024-03-13 02:02:51 +00:00 committed by Gerrit Code Review
parent 662d02fde5
commit 05c5755220
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
c539e979e936eaba8d69fbcfc7601f5707c0a751
View File

@ -135,6 +135,30 @@
},
"revId": "c539e979e936eaba8d69fbcfc7601f5707c0a751",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4e4b153e_3e79c1a3",
"filename": "tacker/tests/unit/policies/test_vnf_package.py",
"patchSetId": 5
},
"lineNbr": 244,
"author": {
"id": 8556
},
"writtenOn": "2024-03-13T02:02:51Z",
"side": 1,
"message": "I see, you are right. I saw now that it only update onboarding_state if that is \u0027ONBOARDED\u0027. as we are passing operationalState as \u0027ENABLED\u0027, it will pass as you mentioned. I will update test as you suggested, thanks for testing it.\n\n- https://github.com/openstack/tacker/blob/d19541340a3e722ceb7d0606d31a59c8cdfa35b8/tacker/api/vnfpkgm/v1/controller.py#L544\n- https://github.com/openstack/tacker/blob/d19541340a3e722ceb7d0606d31a59c8cdfa35b8/tacker/api/vnfpkgm/v1/controller.py#L555",
"parentUuid": "4afab75f_4251d468",
"range": {
"startLine": 244,
"startChar": 61,
"endLine": 244,
"endChar": 77
},
"revId": "c539e979e936eaba8d69fbcfc7601f5707c0a751",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}