Update patch set 4
Patch Set 4: Code-Review-1 (10 comments) Patch-set: 4 Reviewer: Gerrit User 33455 <33455@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 33455 \u003c33455@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Hiromu Asahina replied on the change"} Attention: {"person_ident":"Gerrit User 33492 \u003c33492@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Hiromu Asahina replied on the change"}
This commit is contained in:
parent
365bee5c95
commit
07649c15ae
|
@ -0,0 +1,216 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3a53ddfc_d43a954d",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": "Thank you for the patch \n\nPlease kindly find my comments.",
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e389643e_e1e31145",
|
||||
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 43,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": "nits.\n\nMaybe it\u0027s better to explain that a VNF must be in INSTANTIATED state.\n\n```\nAt least one VNF instance with status of INSTANTIATED is required.\nYou can refer to :doc:`./etsi_containerized_vnf_usage_guide` for the\nprocedure to instantiate VNF.\n```",
|
||||
"range": {
|
||||
"startLine": 41,
|
||||
"startChar": 0,
|
||||
"endLine": 43,
|
||||
"endChar": 36
|
||||
},
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "84917d58_6da5ef7c",
|
||||
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 54,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": "If you agree with the above comment. This line can be removed. IMO, the reference to etsi_vnf_deployment_as_vm_with_tosca can be misleading.",
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6d11bc2a_bfcb47ba",
|
||||
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 65,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": "nits.\n\n```\nVNF\n```\n\nPlease replace all vnf to VNF in the text except for proper nouns like commands, variables and file names.",
|
||||
"range": {
|
||||
"startLine": 65,
|
||||
"startChar": 23,
|
||||
"endLine": 65,
|
||||
"endChar": 26
|
||||
},
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c210d653_f7b61e47",
|
||||
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 74,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": "nits\n```\n``sample_param_file_for_specified_resources.json:``\n```\n\nPlease use back quotes for all filenames and variables, following the styles in other documents [1,2].\n\n[1] https://docs.openstack.org/tacker/latest/user/mgmt_driver_deploy_k8s_usage_guide.html\n[2] https://docs.openstack.org/tacker/latest/install/devstack.html",
|
||||
"range": {
|
||||
"startLine": 74,
|
||||
"startChar": 0,
|
||||
"endLine": 74,
|
||||
"endChar": 46
|
||||
},
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6fb9b294_6bf3c9ef",
|
||||
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 112,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": "```\n``vdu-params``\n```",
|
||||
"range": {
|
||||
"startLine": 112,
|
||||
"startChar": 16,
|
||||
"endLine": 112,
|
||||
"endChar": 26
|
||||
},
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "bc1ead08_cc894b6c",
|
||||
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 119,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": ", but Yoga version Tacker only supports",
|
||||
"range": {
|
||||
"startLine": 118,
|
||||
"startChar": 48,
|
||||
"endLine": 119,
|
||||
"endChar": 13
|
||||
},
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2df163a3_2b75eb55",
|
||||
"filename": "doc/source/user/etsi_vnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 41,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": "nits.\n\nMaybe it\u0027s better to explain that a VNF must be in INSTANTIATED state.\n\n```\nAt least one VNF instance with status of INSTANTIATED is required.\nYou can refer to :doc:`./etsi_vnf_deployment_as_vm_with_tosca` \u003cPLEASE CONFIRM THIS LINK WILL WORK\u003e for the\nprocedure to instantiate VNF.\n```",
|
||||
"range": {
|
||||
"startLine": 40,
|
||||
"startChar": 0,
|
||||
"endLine": 41,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f1737bdc_23f8f7ab",
|
||||
"filename": "doc/source/user/etsi_vnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": "If you agree with the above comment. This line can be removed.",
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "089bafdc_171f1e96",
|
||||
"filename": "doc/source/user/etsi_vnf_change_current_vnf_package.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 176,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-04-27T10:06:46Z",
|
||||
"side": 1,
|
||||
"message": ", but Yoga version Tacker only supports",
|
||||
"range": {
|
||||
"startLine": 175,
|
||||
"startChar": 42,
|
||||
"endLine": 176,
|
||||
"endChar": 12
|
||||
},
|
||||
"revId": "fe920d9c12f21252c7e65044c0c1a249aa9a0c22",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue