openstack/tacker
Code Issues Proposed changes

Openstack VIM Registration Fix

Browse Source 
The fix replaces the faulty endpoint query with a proper
implementation that constructs the full Keystone URL and
uses the correct session method for authenticated requests.

Change-Id: I99e9018e52589474806cd4673a26436e6bce335a
Signed-off-by: Ashutosh Mishra <ashutosh.mishra1@india.nec.com>
Signed-off-by: Shivam Shukla <shivam.shukla3@india.nec.com>
This commit is contained in:
Ashutosh Mishra
2026-02-16 16:31:14 +00:00
parent 98a82a5c99
commit 07a010416f
2 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tacker/nfvo/drivers/vim/openstack_driver.py
+5 -1
View File
@@ -145,7 +145,11 @@ class OpenStack_Driver(abstract_vim_driver.VimAbstractDriver):
def _find_regions(self, ks_client):
# TODO(h-asahina): implement this method into KeystoneClient module
resp = ks_client.get('/v3/regions')
auth_url = str(ks_client.session.auth.auth_url).rstrip('/')
if auth_url.endswith('/v3'):
auth_url = auth_url[:-3]
regions_url = auth_url + '/v3/regions'
resp = ks_client.session.get(regions_url, authenticated=True)
return [region['id'] for region in resp.json().get('regions', [])]
def discover_placement_attr(self, vim_obj, ks_client):
tacker/tests/unit/nfvo/drivers/vim/test_openstack_driver.py
+18 -5
View File
@@ -157,10 +157,21 @@ class TestOpenstack_Driver(base.TestCase):
def test_register_keystone_v3(self):
regions = mock_dict(regions=[{'id': 'RegionOne'}])
attrs = {'get.return_value.json.return_value': regions}
mock_ks_client = mock.Mock(**attrs)
mock_session = mock.Mock()
mock_auth = mock.Mock()
mock_auth.auth_url = 'http://localhost/identity'
mock_session.auth = mock_auth
mock_response = mock.Mock()
mock_response.json.return_value = regions
mock_response.raise_for_status = mock.Mock()
mock_session.get.return_value = mock_response
mock_ks_client = mock.Mock()
mock_ks_client.session = mock_session
expected_regions_url = 'http://localhost/identity/v3/regions'
self._test_register_vim(self.vim_obj, mock_ks_client)
mock_ks_client.get.assert_called_once_with('/v3/regions')
mock_session.get.assert_called_once_with(expected_regions_url,
authenticated=True)
self.keystone.initialize_client.assert_called_once_with(
**self.auth_obj)
@@ -230,12 +241,14 @@ class TestOpenstack_Driver(base.TestCase):
def _test_register_vim_auth(self, attrs):
keystone_version = 'v3'
self.keystone.get_version.return_value = keystone_version
mock_ks_client = mock.Mock(**attrs)
mock_ks_client = mock.Mock()
mock_ks_client.session.get.side_effect = attrs['get.side_effect']
mock_ks_client.session.auth.auth_url = "http://localhost/identity"
self.keystone.initialize_client.return_value = mock_ks_client
self.assertRaises(nfvo.VimUnauthorizedException,
self.openstack_driver.register_vim,
self.vim_obj)
mock_ks_client.get.assert_called_once_with('/v3/regions')
mock_ks_client.session.get.assert_called_once()
self.keystone.initialize_client.assert_called_once_with(
**self.auth_obj)