openstack
/
tacker
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(5 comments)

Patch-set: 5
Reviewer: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 33492 \u003c33492@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Ayumu Ueha replied on the change"}
Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Ayumu Ueha replied on the change"}
This commit is contained in:
Gerrit User 31857 2021-10-27 06:18:28 +00:00 committed by Gerrit Code Review
parent 2482269d49
commit 1c3514d462
2 changed files with 116 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
8cc583674c8ee782fcb677638ba62b23255f84a2
View File

@ -47,6 +47,30 @@
"revId": "8cc583674c8ee782fcb677638ba62b23255f84a2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "670802ed_0154b240",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 20,
"author": {
"id": 31857
},
"writtenOn": "2021-10-27T06:18:28Z",
"side": 1,
"message": "I\u0027ve confirmed.",
"parentUuid": "4c741ae2_fe4bfb24",
"range": {
"startLine": 20,
"startChar": 42,
"endLine": 20,
"endChar": 52
},
"revId": "8cc583674c8ee782fcb677638ba62b23255f84a2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -94,6 +118,30 @@
"revId": "8cc583674c8ee782fcb677638ba62b23255f84a2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f4e87057_d0ef8aa9",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 26,
"author": {
"id": 31857
},
"writtenOn": "2021-10-27T06:18:28Z",
"side": 1,
"message": "I\u0027ve confirmed.",
"parentUuid": "22bbc2ee_fc014078",
"range": {
"startLine": 26,
"startChar": 0,
"endLine": 26,
"endChar": 73
},
"revId": "8cc583674c8ee782fcb677638ba62b23255f84a2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -141,6 +189,30 @@
"revId": "8cc583674c8ee782fcb677638ba62b23255f84a2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f2bcca3a_b04ff542",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 32,
"author": {
"id": 31857
},
"writtenOn": "2021-10-27T06:18:28Z",
"side": 1,
"message": "I\u0027ve confirmed.",
"parentUuid": "5089e406_e54fe791",
"range": {
"startLine": 32,
"startChar": 0,
"endLine": 32,
"endChar": 73
},
"revId": "8cc583674c8ee782fcb677638ba62b23255f84a2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {

44
90c934eb90785326354bbfa8f85dd9ca0622bd77 Normal file
View File

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "50fd119d_54b88d6b",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 15,
"author": {
"id": 31857
},
"writtenOn": "2021-10-27T06:18:28Z",
"side": 1,
"message": "typo: \"scale\" is correct.",
"range": {
"startLine": 15,
"startChar": 10,
"endLine": 15,
"endChar": 16
},
"revId": "90c934eb90785326354bbfa8f85dd9ca0622bd77",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "47c42cb6_4002ed3a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2021-10-27T06:18:28Z",
"side": 1,
"message": "Thanks for rework. There is additional typo. Could you revise it?",
"revId": "90c934eb90785326354bbfa8f85dd9ca0622bd77",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}