openstack
/
tacker
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(3 comments)

Patch-set: 7
Reviewer: Gerrit User 31072 <31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 31072 2022-05-17 06:58:49 +00:00 committed by Gerrit Code Review
parent e468c241b6
commit 1fce49f0ec
1 changed files with 57 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
d3635fae6958c0087be54c5d85e7b7620566c06a
View File

@ -22,6 +22,63 @@
},
"revId": "d3635fae6958c0087be54c5d85e7b7620566c06a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "080c5215_551d30d2",
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
"patchSetId": 7
},
"lineNbr": 75,
"author": {
"id": 31072
},
"writtenOn": "2022-05-17T06:58:49Z",
"side": 1,
"message": "I think there is not enough information about the \"additionalParams\" setting.\nHow about adding the information of \"additional Params\" as defined in the following Spec?\n---\nhttps://specs.openstack.org/openstack/tacker-specs/specs/yoga/upgrade-vnf-package.html",
"revId": "d3635fae6958c0087be54c5d85e7b7620566c06a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4ea25d57_4493f602",
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
"patchSetId": 7
},
"lineNbr": 77,
"author": {
"id": 31072
},
"writtenOn": "2022-05-17T06:58:49Z",
"side": 1,
"message": "It\u0027s better to add a brief explanation about the coordinate script itself.\nIn my understanding, this script is specific implementation in Tacker, simulating the \"coordination interface\" defined in SOL002 v3.5.1.",
"revId": "d3635fae6958c0087be54c5d85e7b7620566c06a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "593a1935_2dc4559d",
"filename": "doc/source/user/etsi_cnf_change_current_vnf_package.rst",
"patchSetId": 7
},
"lineNbr": 108,
"author": {
"id": 31072
},
"writtenOn": "2022-05-17T06:58:49Z",
"side": 1,
"message": "As with `` vdu_params``, it\u0027s better to describe somewhere that `` lcm-kubernetes-def-files`` is required for kubernetes VIM and not requreid for openstack VIM.",
"range": {
"startLine": 106,
"startChar": 3,
"endLine": 108,
"endChar": 30
},
"revId": "d3635fae6958c0087be54c5d85e7b7620566c06a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}