openstack/tacker
Code Issues Proposed changes

Update hacking

Browse Source 
This Patch updates hacking from
<0.10,>=0.9.2 to <0.11,>=0.10.2,
and fixes W292, H238, H105 errors.

W292 no newline at end of file
H238 old style class declaration, use new style (inherit from `object`)
H105 Don't use author tags

Change-Id: Ic2f9fc8f5adf62192f0cf2e775e095943ed4c070
Related-Bug: 1515930
This commit is contained in:
Martin Oemke 2016-01-01 18:44:15 +01:00
parent 21ea0312ac
commit 216082b439
36 changed files with 7 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tacker/agent/linux/daemon.py
View File

@ -13,8 +13,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Mark McClain, DreamHost
import atexit
import fcntl

2
tacker/agent/linux/external_process.py
View File

@ -13,8 +13,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Mark McClain, DreamHost
import os

2
tacker/agent/linux/utils.py
View File

@ -14,8 +14,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Juliano Martinez, Locaweb.
import fcntl
import os

1
tacker/api/v1/resource_helper.py
View File

@ -12,7 +12,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
# @author: Paul Michali Cisco Systems, Inc.
from oslo_config import cfg

1
tacker/common/driver_manager.py
View File

@ -18,7 +18,6 @@
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import logging as log

1
tacker/common/log.py
View File

@ -1,6 +1,5 @@
# Copyright (C) 2013 eNovance SAS <licensing@enovance.com>
#
# Author: Sylvain Afchain <sylvain.afchain@enovance.com>
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain

2
tacker/db/migration/__init__.py
View File

@ -11,8 +11,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Mark McClain, DreamHost
from alembic import op
import sqlalchemy as sa

2
tacker/db/migration/alembic_migrations/env.py
View File

@ -11,8 +11,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Mark McClain, DreamHost
from logging import config as logging_config

2
tacker/db/migration/alembic_migrations/versions/1c6b0d82afcd_servicevm_framework.py
View File

@ -16,8 +16,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
"""add tables for servicevm framework

2
tacker/db/migration/cli.py
View File

@ -11,8 +11,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Mark McClain, DreamHost
import os

2
tacker/db/vm/proxy_db.py
View File

@ -15,8 +15,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import sqlalchemy as sa

2
tacker/db/vm/vm_db.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import uuid

3
tacker/tests/tools.py
View File

@ -12,9 +12,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Akihiro Motoki, NEC Corporation
"""setup_mock_calls and verify_mock_calls are convenient methods
to setup a sequence of mock calls.

2
tacker/tests/unit/database_stubs.py
View File

@ -14,8 +14,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Rohit Agarwalla, Cisco Systems, Inc.
"""stubs.py provides interface methods for the database test cases"""

2
tacker/tests/unit/extensions/extendedattribute.py
View File

@ -13,8 +13,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Kaiwei Fan, VMware, Inc
from tacker.api import extensions

3
tacker/tests/unit/extensions/extensionattribute.py
View File

@ -14,9 +14,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Kaiwei Fan, VMware, Inc
#
import abc

2
tacker/tests/unit/services/vm/test_servicevm_extension.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import copy
import uuid

3
tacker/tests/unit/test_api_api_common.py
View File

@ -14,9 +14,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Zhongyue Luo, Intel Corporation.
#
from testtools import matchers
from webob import exc

2
tacker/tests/unit/test_api_v2.py
View File

@ -1350,7 +1350,7 @@ class ExtensionTestCase(base.BaseTestCase):
self.assertNotIn('v2attrs:something_else', net)
class TestSubresourcePlugin():
class TestSubresourcePlugin(object):
def get_network_dummies(self, context, network_id,
filters=None, fields=None):
return []

2
tacker/tests/unit/test_api_v2_extension.py
View File

@ -15,8 +15,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import uuid

3
tacker/tests/unit/test_api_v2_resource.py
View File

@ -14,9 +14,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Zhongyue Luo, Intel Corporation.
#
import mock
from webob import exc

4
tacker/tests/unit/test_wsgi.py
View File

@ -783,7 +783,7 @@ class ResourceTest(base.BaseTestCase):
def my_fault_body_function():
return 'off'
class FakeRequest():
class FakeRequest(object):
def __init__(self):
self.url = 'http://where.no'
self.environ = 'environ'
@ -823,7 +823,7 @@ class ResourceTest(base.BaseTestCase):
def my_fault_body_function():
return 'off'
class FakeRequest():
class FakeRequest(object):
def __init__(self):
self.url = 'http://where.no'
self.environ = 'environ'

2
tacker/vm/constants.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
# sevice type
SVC_TYPE_ROUTER = 'router'

2
tacker/vm/drivers/abstract_driver.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import abc

2
tacker/vm/drivers/heat/heat.py
View File

@ -447,7 +447,7 @@ class DeviceHeat(abstract_driver.DeviceAbstractDriver):
raise NotImplementedError()
class HeatClient:
class HeatClient(object):
def __init__(self, context, password=None):
# context, password are unused
self.stacks = clients.OpenstackClients().heat.stacks

3
tacker/vm/drivers/noop.py
View File

@ -17,8 +17,7 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
# TODO(yamahata): once unittests are impletemted, move this there
import uuid

2
tacker/vm/drivers/nova/nova.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import time

2
tacker/vm/hosting_device_scheduler.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import random

2
tacker/vm/mgmt_drivers/abstract_driver.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import abc

2
tacker/vm/mgmt_drivers/constants.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
# key
KEY_ACTION = 'action'

2
tacker/vm/mgmt_drivers/noop.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
from tacker.openstack.common import log as logging
from tacker.vm.mgmt_drivers import abstract_driver

2
tacker/vm/mgmt_drivers/openwrt/openwrt.py
View File

@ -15,8 +15,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
from oslo_config import cfg
import yaml

2
tacker/vm/monitor.py
View File

@ -15,8 +15,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import abc
import inspect

2
tacker/vm/plugin.py
View File

@ -17,8 +17,6 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# @author: Isaku Yamahata, Intel Corporation.
import copy
import inspect

2
test-requirements.txt
View File

@ -10,7 +10,7 @@ coverage>=3.6
discover
doc8 # Apache-2.0
fixtures>=1.3.1
hacking<0.10,>=0.9.2
hacking<0.11,>=0.10.2
mock>=1.2
python-subunit>=0.0.18
ordereddict