openstack
/
tacker
Code Issues Proposed changes

the http response code is not accurate 

When Unsupported Content-Type, it is best to return
HTTPUnsupportedMediaType

Change-Id: If0c11e2ab4645d2acc61c9845c0abd6e12a40df9
This commit is contained in:
Li Jiale 2018-11-11 18:53:15 +08:00 committed by Yan Xing an
parent 53c78de6ca
commit 2350cc7496
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tacker/tests/unit/test_wsgi.py
View File

@ -616,7 +616,7 @@ class ResourceTest(base.BaseTestCase):
resource = wsgi.Resource(Controller(), my_fault_body_function)
request = FakeRequest()
result = resource(request)
self.assertEqual(400, result.status_int)
self.assertEqual(415, result.status_int)
def test_type_error(self):
class Controller(object):

2
tacker/wsgi.py
View File

@ -787,7 +787,7 @@ class Resource(Application):
action, args, accept = self.deserializer.deserialize(request)
except exception.InvalidContentType:
LOG.exception("InvalidContentType: Unsupported Content-Type")
return Fault(webob.exc.HTTPBadRequest(
return Fault(webob.exc.HTTPUnsupportedMediaType(
explanation=_("Unsupported Content-Type")))
except exception.MalformedRequestBody:
LOG.exception("MalformedRequestBody: Malformed request body")