openstack
/
tacker
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+1

(3 comments)

Looks good.  One clarification and a couple of nits.

Patch-set: 3
Label: Code-Review=+1
This commit is contained in:
Gerrit User 16511 2015-10-19 02:11:40 +00:00 committed by Gerrit Code Review
parent e6ea46cebf
commit 2545c18104
1 changed files with 51 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
243cfd4578f81f06505f73cd6b1955f8f79b9a80
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"key": {
"uuid": "5a2ca52d_db573d56",
"filename": "doc/source/devref/vnfd_template_parameterization.rst",
"patchSetId": 3
},
"lineNbr": 8,
"author": {
"id": 16511
},
"writtenOn": "2015-10-19T02:11:40Z",
"side": 1,
"message": "A non-parameterized VNFD could be deployed multiple times and get different IP addresses, retrieve it\u0027s own configuration from an external manager, repository, etc. Maybe say \"has static values for the parameters that might limit the number of concurrent VNFs that can be deployed using a single VNFD\"",
"revId": "243cfd4578f81f06505f73cd6b1955f8f79b9a80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a29b11f_2c63591c",
@ -34,6 +51,40 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a2ca52d_dbde5ddc",
"filename": "doc/source/devref/vnfd_template_parameterization.rst",
"patchSetId": 3
},
"lineNbr": 201,
"author": {
"id": 16511
},
"writtenOn": "2015-10-19T02:11:40Z",
"side": 1,
"message": "Nit - multiple VNF deployments",
"revId": "243cfd4578f81f06505f73cd6b1955f8f79b9a80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a2ca52d_9be465ac",
"filename": "doc/source/devref/vnfd_template_parameterization.rst",
"patchSetId": 3
},
"lineNbr": 206,
"author": {
"id": 16511
},
"writtenOn": "2015-10-19T02:11:40Z",
"side": 1,
"message": "Nit - during VNF deployment",
"revId": "243cfd4578f81f06505f73cd6b1955f8f79b9a80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a29b11f_cc7425d1",