openstack/tacker
Code Issues Proposed changes

Add negative FT for subscription in multi tenancy

Browse Source 
In a multi-tenant environment, the user's request to show
or delete subscription of a different tenant, must fail.

This patch adds negative functional test cases for subscription
show and delete operation.

Implements: bp enhance-multi-tenant-policy
Change-Id: Ie44116364089e06c86e4c3dcd207c5a720e6e4a4
This commit is contained in:
Manpreet Kaur 2022-06-16 13:54:08 +05:30
parent fec4f537fb
commit 2fceb352df
1 changed files with 24 additions and 8 deletions

32
tacker/tests/functional/sol_multi_tenant/vnflcm/test_vnf_lcm_with_multi_tenant.py

@ -168,22 +168,18 @@ class VnfLcmWithMultiTenant(base.BaseVnfLcmMultiTenantTest):
- Show Subscription - Show Subscription
- User A only gets information about Subscription A. - User A only gets information about Subscription A.
- User B only gets information about Subscription B. - User B only gets information about Subscription B.
- User A fails to get information about Subscription B.
- User B fails to get information about Subscription A.
- List Subscription - List Subscription
- User A gets subscription list and confirms only - User A gets subscription list and confirms only
Subscription A is output. Subscription A is output.
- User B gets subscription list and confirms only - User B gets subscription list and confirms only
Subscription B is output. Subscription B is output.
- Delete Subscription - Delete Subscription
- User A deletes Subscription A.
- User B deletes Subscription B.
TODO(manpreetk): Only positive test cases are validated in
Y-release.
Negative test cases
- User A fails to delete Subscription B. - User A fails to delete Subscription B.
- User B fails to delete Subscription A. - User B fails to delete Subscription A.
Validation of negative test cases would require design changes - User A deletes Subscription A.
in Fake NFVO server, which could be implemented in the upcoming - User B deletes Subscription B.
cycle.
""" """
# Create subscription # Create subscription
# User A registers Subscription A. # User A registers Subscription A.
@ -229,6 +225,16 @@ class VnfLcmWithMultiTenant(base.BaseVnfLcmMultiTenantTest):
subscription_id_t2, self.tacker_client_t2) subscription_id_t2, self.tacker_client_t2)
self.assert_subscription_show(resp_t2, resp_body_show_t2) self.assert_subscription_show(resp_t2, resp_body_show_t2)
# User A fails to get information for Subscription B
resp_tx1, resp_body_show_tx1 = self._wait_show_subscription(
subscription_id_t2, self.tacker_client_t1)
self.assertEqual(404, resp_tx1.status_code)
# User B fails to get information for Subscription A
resp_tx2, resp_body_show_tx2 = self._wait_show_subscription(
subscription_id_t1, self.tacker_client_t2)
self.assertEqual(404, resp_tx2.status_code)
# List Subscription # List Subscription
# User A gets subscription list # User A gets subscription list
resp, _ = self._list_subscription(self.tacker_client_t1) resp, _ = self._list_subscription(self.tacker_client_t1)
@ -260,6 +266,16 @@ class VnfLcmWithMultiTenant(base.BaseVnfLcmMultiTenantTest):
self.assertEqual(1, len(subscription_body_t2)) self.assertEqual(1, len(subscription_body_t2))
# Delete subscription # Delete subscription
# User A fails to delete Subscription B
resp, _ = self._delete_subscription(subscription_id_t2,
self.tacker_client_t1)
self.assertEqual(404, resp.status_code)
# User B fails to delete Subscription A
resp, _ = self._delete_subscription(subscription_id_t1,
self.tacker_client_t2)
self.assertEqual(404, resp.status_code)
# User A deletes Subscription A # User A deletes Subscription A
self.addCleanup(self._delete_subscription, self.addCleanup(self._delete_subscription,
subscription_id_t1, self.tacker_client_t1) subscription_id_t1, self.tacker_client_t1)