openstack
/
tacker
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(4 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 4149 \u003c4149@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Hiroo Kitamura replied on the change"}
Attention: {"person_ident":"Gerrit User 31072 \u003c31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Hiroo Kitamura replied on the change"}
This commit is contained in:
Gerrit User 31072 2021-12-23 00:06:33 +00:00 committed by Gerrit Code Review
parent f8dc1aae85
commit 34e75b5b69
2 changed files with 87 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
14fed99218fae96c567a7918e6bb1d4393274487 Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "cce8b823_16a7e9fb",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 5
},
"lineNbr": 508,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T00:06:33Z",
"side": 1,
"message": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py L156\ntacker/sol_refactored/conductor/vnflcm_driver_v2.py L506\ntacker/sol_refactored/controller/vnflcm_v2.py L244\n---\nAlthough it is related to what I have already commented on, I think that the code considering the following is defined in the above 3 points about \"numberOfSteps\".\n* 1 is set as the initial value and it will be overwrited when it is set in the request-body\n* For Scale-in, multiply by -1\nIs it possible to eliminate the need for consideration in each code by commonizing this process as a new util function?",
"range": {
"startLine": 506,
"startChar": 8,
"endLine": 508,
"endChar": 41
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

60
5fe32c386a1207294b8a1c5ea35274556d7d4b44
View File

@ -100,6 +100,30 @@
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "980c3ac9_7e67a4a0",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 3
},
"lineNbr": 152,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T00:06:33Z",
"side": 1,
"message": "Okay, I see.",
"parentUuid": "974c11f1_f8e15d9d",
"range": {
"startLine": 149,
"startChar": 0,
"endLine": 152,
"endChar": 73
},
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -135,6 +159,24 @@
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "995f0833_f37c587e",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 3
},
"lineNbr": 156,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T00:06:33Z",
"side": 1,
"message": "Done",
"parentUuid": "4d189574_247d3213",
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -169,6 +211,24 @@
"parentUuid": "0e4a0d8d_6e50c8c8",
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dffaf29d_5376e13e",
"filename": "tacker/sol_refactored/controller/vnflcm_v2.py",
"patchSetId": 3
},
"lineNbr": 244,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T00:06:33Z",
"side": 1,
"message": "Done",
"parentUuid": "adf8a118_bca4028e",
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}