openstack
/
tacker
Code Issues Proposed changes

Update patch set 14 

Patch Set 14:

(10 comments)

Patch-set: 14
This commit is contained in:
Gerrit User 33492 2022-05-19 01:39:46 +00:00 committed by Gerrit Code Review
parent 2412b5512a
commit 380334fa89
1 changed files with 227 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

227
00389ac09d2f41a212fa8a6feb9c0148f896c908
View File

@ -17,6 +17,23 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "11e503b1_9f7c348a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 14
},
"lineNbr": 0,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "To Ai Hamano:\nThank you for your comments. I fixed them in PS15.\nPlease kindly check them again.",
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -40,6 +57,30 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e299e73b_50af6058",
"filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py",
"patchSetId": 14
},
"lineNbr": 59,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "I deleted these comments in PS15.",
"parentUuid": "5f26db3d_9e370eed",
"range": {
"startLine": 22,
"startChar": 0,
"endLine": 59,
"endChar": 11
},
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -63,6 +104,30 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bb579a43_cc2f6ffb",
"filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py",
"patchSetId": 14
},
"lineNbr": 93,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "ditto",
"parentUuid": "3bbd7d7d_4c6a16ac",
"range": {
"startLine": 63,
"startChar": 0,
"endLine": 93,
"endChar": 11
},
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +151,30 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5212ac7d_d9ee664e",
"filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py",
"patchSetId": 14
},
"lineNbr": 110,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "ditto",
"parentUuid": "4dc1fc55_2b1e27c1",
"range": {
"startLine": 97,
"startChar": 0,
"endLine": 110,
"endChar": 11
},
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -109,6 +198,30 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "68d483bf_13885d52",
"filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py",
"patchSetId": 14
},
"lineNbr": 142,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "ditto",
"parentUuid": "5ca1314d_a92d72b9",
"range": {
"startLine": 114,
"startChar": 0,
"endLine": 142,
"endChar": 11
},
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -132,6 +245,30 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e9ee3612_a1c3a396",
"filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py",
"patchSetId": 14
},
"lineNbr": 166,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "ditto",
"parentUuid": "53e992de_70d49440",
"range": {
"startLine": 146,
"startChar": 0,
"endLine": 166,
"endChar": 11
},
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -155,6 +292,30 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "39b32c42_0aff12bb",
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
"patchSetId": 14
},
"lineNbr": 185,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "I fixed it in PS15.",
"parentUuid": "4f874147_981ce48a",
"range": {
"startLine": 185,
"startChar": 42,
"endLine": 185,
"endChar": 46
},
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -178,6 +339,30 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6d233709_eac4efde",
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
"patchSetId": 14
},
"lineNbr": 194,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "I fixed it in PS15.",
"parentUuid": "01887502_cd3b4d4e",
"range": {
"startLine": 194,
"startChar": 43,
"endLine": 194,
"endChar": 48
},
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -201,6 +386,30 @@
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3235f024_5fab87de",
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
"patchSetId": 14
},
"lineNbr": 195,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "I fixed it in PS15.",
"parentUuid": "1c2403d8_f000d501",
"range": {
"startLine": 195,
"startChar": 43,
"endLine": 195,
"endChar": 47
},
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -217,6 +426,24 @@
"message": "Would you please add a comment about attributes, operations, etc. like other tests?",
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a542d286_b89466b7",
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
"patchSetId": 14
},
"lineNbr": 1617,
"author": {
"id": 33492
},
"writtenOn": "2022-05-19T01:39:46Z",
"side": 1,
"message": "I added this comments in PS15.",
"parentUuid": "68cb4197_5839051f",
"revId": "00389ac09d2f41a212fa8a6feb9c0148f896c908",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}