Browse Source

Update patch set 3

Patch Set 3: Code-Review-1

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
changes/47/825047/meta
Gerrit User 31857 4 months ago committed by Gerrit Code Review
parent
commit
40f77b0ce0
  1. 67
      c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9

67
c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9

@ -0,0 +1,67 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "aa0cec00_60873a0d",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 10,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T02:56:23Z",
"side": 1,
"message": "typo: ETSI",
"range": {
"startLine": 10,
"startChar": 3,
"endLine": 10,
"endChar": 7
},
"revId": "c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "83ab74f6_e2dcea67",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T02:56:23Z",
"side": 1,
"message": "Thanks for your patch, please kindly check my comments.",
"revId": "c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9c17491a_7c18e229",
"filename": "tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py",
"patchSetId": 3
},
"lineNbr": 1590,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T02:56:23Z",
"side": 1,
"message": "The current failure in sol_kubernetes job seems because of access error to `vnf_instance.vnf_metadata`.\n\nI think that the same check as [1] is necessary here like below.\nhttps://review.opendev.org/c/openstack/tacker/+/825047/3/tacker/vnfm/infra_drivers/kubernetes/utils.py#64\n```\n if not vnf_instance.vnf_metadata:\n vnf_instance.vnf_metadata \u003d {}\n```",
"range": {
"startLine": 1590,
"startChar": 12,
"endLine": 1590,
"endChar": 62
},
"revId": "c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
Loading…
Cancel
Save