Update patch set 16
Patch Set 16: (6 comments) Patch-set: 16 Attention: {"person_ident":"Gerrit User 33455 \u003c33455@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34226\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 34226 \u003c34226@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34226\u003e replied on the change"}
This commit is contained in:
parent
5648ef29ae
commit
4734a4b67e
|
@ -34,6 +34,23 @@
|
|||
"revId": "17b6a1ab8f79ec95f6014ab4c03422b67adffcd9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c62ea47f_7aad3d98",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 16
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 34226
|
||||
},
|
||||
"writtenOn": "2023-01-30T06:32:15Z",
|
||||
"side": 1,
|
||||
"message": "Thank you for the review.",
|
||||
"revId": "17b6a1ab8f79ec95f6014ab4c03422b67adffcd9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
@ -51,6 +68,24 @@
|
|||
"revId": "17b6a1ab8f79ec95f6014ab4c03422b67adffcd9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "8b58475b_f3bbd5e5",
|
||||
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
||||
"patchSetId": 16
|
||||
},
|
||||
"lineNbr": 645,
|
||||
"author": {
|
||||
"id": 34226
|
||||
},
|
||||
"writtenOn": "2023-01-30T06:32:15Z",
|
||||
"side": 1,
|
||||
"message": "I will add a discription.",
|
||||
"parentUuid": "b752a03f_7cc09574",
|
||||
"revId": "17b6a1ab8f79ec95f6014ab4c03422b67adffcd9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
@ -67,6 +102,24 @@
|
|||
"message": "nits.\n\nNaming \"sets\" as \"*_list\" is a little bit confusing as they have different methods. How about just `zones`.\nSame for others.",
|
||||
"revId": "17b6a1ab8f79ec95f6014ab4c03422b67adffcd9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "99a6782a_0568ffb8",
|
||||
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
||||
"patchSetId": 16
|
||||
},
|
||||
"lineNbr": 657,
|
||||
"author": {
|
||||
"id": 34226
|
||||
},
|
||||
"writtenOn": "2023-01-30T06:32:15Z",
|
||||
"side": 1,
|
||||
"message": "It may be better, but this valiable name \"list\" is used as a common noun, not as a python class. Is this all right with you?",
|
||||
"parentUuid": "794604d4_24b8e3d6",
|
||||
"revId": "17b6a1ab8f79ec95f6014ab4c03422b67adffcd9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
|
@ -156,6 +156,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b296fc0b_dd782f75",
|
||||
"filename": "roles/setup-multi-az/tasks/main.yaml",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 14,
|
||||
"author": {
|
||||
"id": 34226
|
||||
},
|
||||
"writtenOn": "2023-01-30T06:32:15Z",
|
||||
"side": 1,
|
||||
"message": "I wil add comments.",
|
||||
"parentUuid": "86f0e5b4_d68cce1f",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
@ -214,6 +232,30 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b51a6fd2_3b9ddd4a",
|
||||
"filename": "tacker/sol_refactored/common/config.py",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 80,
|
||||
"author": {
|
||||
"id": 34226
|
||||
},
|
||||
"writtenOn": "2023-01-30T06:32:15Z",
|
||||
"side": 1,
|
||||
"message": "I will add a message.",
|
||||
"parentUuid": "29f3e989_ba08dc12",
|
||||
"range": {
|
||||
"startLine": 80,
|
||||
"startChar": 23,
|
||||
"endLine": 80,
|
||||
"endChar": 71
|
||||
},
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
@ -284,6 +326,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2e8fd619_d5961557",
|
||||
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 640,
|
||||
"author": {
|
||||
"id": 34226
|
||||
},
|
||||
"writtenOn": "2023-01-30T06:32:15Z",
|
||||
"side": 1,
|
||||
"message": "I will add.",
|
||||
"parentUuid": "6a3f9d79_94748639",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
Loading…
Reference in New Issue