openstack
/
tacker
Code Issues Proposed changes

Update patch set 10 

Patch Set 10:

(3 comments)

Patch-set: 10
This commit is contained in:
Gerrit User 4149 2024-03-11 23:15:59 +00:00 committed by Gerrit Code Review
parent 7e689045c2
commit 4a54b266d9
1 changed files with 53 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
30629f871cedaa116dbc5ae0e298ee567af1ca35
View File

@ -17,6 +17,23 @@
"revId": "30629f871cedaa116dbc5ae0e298ee567af1ca35",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "35fde50c_3a5f4588",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2024-03-11T23:15:59Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "30629f871cedaa116dbc5ae0e298ee567af1ca35",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -34,6 +51,24 @@
"revId": "30629f871cedaa116dbc5ae0e298ee567af1ca35",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "455f6bf1_c3e7d1d5",
"filename": "tacker/sol_refactored/api/wsgi.py",
"patchSetId": 10
},
"lineNbr": 274,
"author": {
"id": 4149
},
"writtenOn": "2024-03-11T23:15:59Z",
"side": 1,
"message": "I will fix.",
"parentUuid": "247ef701_15b06d8f",
"revId": "30629f871cedaa116dbc5ae0e298ee567af1ca35",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -50,6 +85,24 @@
"message": "Since this is a test in the TestPrometheusPluginFm class, I think it would be better to change \"test_pm_no_body\" to \"test_fm_no_body\".\nHow about using the class \"PrometheusPluginFm\" instead of \"PrometheusPluginPm\" and testing that SolValidationError occurs?",
"revId": "30629f871cedaa116dbc5ae0e298ee567af1ca35",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4351c0bb_d256436e",
"filename": "tacker/tests/unit/sol_refactored/common/test_prometheus_plugin.py",
"patchSetId": 10
},
"lineNbr": 1428,
"author": {
"id": 4149
},
"writtenOn": "2024-03-11T23:15:59Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "d132c0df_d11c14da",
"revId": "30629f871cedaa116dbc5ae0e298ee567af1ca35",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}