From 4a669a126146ca7f4b277aaee421e9553b079ef4 Mon Sep 17 00:00:00 2001 From: Janki Chhatbar Date: Sun, 26 Jun 2016 20:50:52 +0530 Subject: [PATCH] VNFD Legacy templates deprecated Throws a deprecation warning while using legacy templates for VNF creation. Change-Id: Ie68389e4abd0c7293ec48ed2a380fb7956d8c599 Partial-Bug: #1582928 --- .../deprecate-vnfd-legacy-template-41a0560aee1addc3.yaml | 4 ++++ samples/legacy-templates/README.warning | 6 ++++++ tacker/vm/plugin.py | 6 ++++++ 3 files changed, 16 insertions(+) create mode 100644 releasenotes/notes/deprecate-vnfd-legacy-template-41a0560aee1addc3.yaml create mode 100644 samples/legacy-templates/README.warning diff --git a/releasenotes/notes/deprecate-vnfd-legacy-template-41a0560aee1addc3.yaml b/releasenotes/notes/deprecate-vnfd-legacy-template-41a0560aee1addc3.yaml new file mode 100644 index 000000000..59f7b112d --- /dev/null +++ b/releasenotes/notes/deprecate-vnfd-legacy-template-41a0560aee1addc3.yaml @@ -0,0 +1,4 @@ +--- +deprecations: + - Support for legacy templates for creating a VNFD is deprecated and will be + removed in 'Newton' cycle. Please use TOSCA based templates. diff --git a/samples/legacy-templates/README.warning b/samples/legacy-templates/README.warning new file mode 100644 index 000000000..84428574e --- /dev/null +++ b/samples/legacy-templates/README.warning @@ -0,0 +1,6 @@ +Legacy Template Deprecate Warning +================================= + +From Mitaka version, Tacker supports TOSCA based VNFD templates. Legacy +templates described under tacker/samples/legacy-templates are deprecated. Use +TOSCA based templates described at tacker/samples/tosca-templates diff --git a/tacker/vm/plugin.py b/tacker/vm/plugin.py index 8afcad2ec..6b7f15efd 100644 --- a/tacker/vm/plugin.py +++ b/tacker/vm/plugin.py @@ -21,6 +21,7 @@ import six import eventlet from oslo_config import cfg from oslo_log import log as logging +from oslo_log import versionutils from oslo_utils import excutils from tacker.api.v1 import attributes @@ -128,6 +129,11 @@ class VNFMPlugin(vm_db.VNFMPluginDb, VNFMMgmtMixin): def create_device_template(self, context, device_template): template = device_template['device_template'] + if "tosca_definitions_version" not in template['attributes']['vnfd']: + versionutils.report_deprecated_feature(LOG, 'VNFD legacy templates' + ' are deprecated since Mitaka release and will be removed in' + ' Ocata release. Please use NFV TOSCA templates.') + LOG.debug(_('template %s'), template) infra_driver = template.get('infra_driver')