openstack
/
tacker
Code Issues Proposed changes

Update patch set 14 

Patch Set 14: Code-Review-1

(4 comments)

Patch-set: 14
Reviewer: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 56dcf06cfa9ae6a1b59cbe4847ce7a2ae2ec43ec
Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31857\u003e replied on the change"}
This commit is contained in:
Gerrit User 31857 2024-03-12 14:55:16 +00:00 committed by Gerrit Code Review
parent 9f1b718a2f
commit 5a03885201
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6
View File

@ -40,6 +40,30 @@
"revId": "8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "725abbce_5c5fcabf",
"filename": "doc/source/configuration/policy-concepts.rst",
"patchSetId": 11
},
"lineNbr": 5,
"author": {
"id": 31857
},
"writtenOn": "2024-03-12T14:55:16Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "065ef88e_72875ada",
"range": {
"startLine": 5,
"startChar": 60,
"endLine": 5,
"endChar": 69
},
"revId": "8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -63,6 +87,30 @@
"revId": "8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8438b0c2_2719dccd",
"filename": "doc/source/configuration/policy-concepts.rst",
"patchSetId": 11
},
"lineNbr": 20,
"author": {
"id": 31857
},
"writtenOn": "2024-03-12T14:55:16Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "abb04f61_5d3ee60c",
"range": {
"startLine": 20,
"startChar": 8,
"endLine": 20,
"endChar": 11
},
"revId": "8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +134,30 @@
"revId": "8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "dcdcf26c_85fe8ff8",
"filename": "doc/source/configuration/policy-concepts.rst",
"patchSetId": 11
},
"lineNbr": 258,
"author": {
"id": 31857
},
"writtenOn": "2024-03-12T14:55:16Z",
"side": 1,
"message": "I will confirm just in case, one line has been deleted cleanly, but is it correct?",
"parentUuid": "e1f6e949_d3a45383",
"range": {
"startLine": 258,
"startChar": 10,
"endLine": 258,
"endChar": 21
},
"revId": "8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -108,6 +180,30 @@
},
"revId": "8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "793a5a79_ec4831cc",
"filename": "releasenotes/notes/project-personas-rbac-43f1w16e34b55608yaml",
"patchSetId": 11
},
"lineNbr": 20,
"author": {
"id": 31857
},
"writtenOn": "2024-03-12T14:55:16Z",
"side": 1,
"message": "It doesn\u0027t seem to be fixed.",
"parentUuid": "2705921b_ff631854",
"range": {
"startLine": 20,
"startChar": 15,
"endLine": 20,
"endChar": 24
},
"revId": "8dc0bab9f708a956b45eb2ae2ed84f19e0f239c6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}