openstack
/
tacker
Code Issues Proposed changes

Update patch set 28 

Patch Set 28:

(12 comments)

Patch-set: 28
Attention: {"person_ident":"Gerrit User 31668 \u003c31668@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31668\u003e replied on the change"}
This commit is contained in:
Gerrit User 31668 2024-03-13 10:28:31 +00:00 committed by Gerrit Code Review
parent dba63b0498
commit 5b52adc6ec
3 changed files with 273 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

168
565f4ed0ac412970615e38a212277ca843e8a259
View File

@ -23,6 +23,30 @@
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c607905f_fe22ace7",
"filename": "doc/source/user/etsi_cnf_healing.rst",
"patchSetId": 23
},
"lineNbr": 303,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "The current v1 API requires creating a Default VIM and setting vimConnectionInfo in the request.\nTherefore, the following vimConnectionInfo is set for the VNF Instance after instantiation.\n* Default VIM\n* VIM specified in the request\n\nI think there are still things to consider in the v1 API specifications, but is it okay to write the results according to the current specifications in the current document?",
"parentUuid": "9570a67b_81d5dc7e",
"range": {
"startLine": 296,
"startChar": 0,
"endLine": 303,
"endChar": 40
},
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "76c06ca7_60af864e",
"filename": "doc/source/user/etsi_cnf_healing.rst",
"patchSetId": 23
},
"lineNbr": 444,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "ditto",
"parentUuid": "c138448c_44002a5a",
"range": {
"startLine": 437,
"startChar": 0,
"endLine": 444,
"endChar": 41
},
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d90b6333_9d9d8f84",
"filename": "doc/source/user/etsi_cnf_healing.rst",
"patchSetId": 23
},
"lineNbr": 592,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "ditto",
"parentUuid": "0a8e5fbd_e81a7633",
"range": {
"startLine": 585,
"startChar": 0,
"endLine": 592,
"endChar": 45
},
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -92,6 +164,30 @@
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ca93ff0e_5c18fe6d",
"filename": "doc/source/user/etsi_containerized_vnf_usage_guide.rst",
"patchSetId": 23
},
"lineNbr": 172,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "2 is correct. I fixed it in PS28.",
"parentUuid": "ed50e5d7_3fe4f673",
"range": {
"startLine": 172,
"startChar": 0,
"endLine": 172,
"endChar": 2
},
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -115,6 +211,30 @@
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d29cbd38_acc90b4f",
"filename": "doc/source/user/etsi_containerized_vnf_usage_guide.rst",
"patchSetId": 23
},
"lineNbr": 1016,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "In the current v1 API, two vimConnectionInfo are set.\nIs it okay to write the results according to the current specifications in the current document?",
"parentUuid": "b1c8003d_486951dc",
"range": {
"startLine": 1009,
"startChar": 0,
"endLine": 1016,
"endChar": 41
},
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -138,6 +258,30 @@
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d50d6baf_e9c9b480",
"filename": "doc/source/user/etsi_getting_started.rst",
"patchSetId": 23
},
"lineNbr": 718,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "In the current v1 API, two vimConnectionInfo are set.\nIs it okay to write the results according to the current specifications in the current document?",
"parentUuid": "6cbbe2bb_979caab0",
"range": {
"startLine": 711,
"startChar": 0,
"endLine": 718,
"endChar": 47
},
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -160,6 +304,30 @@
},
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e3683be6_f6d75cb0",
"filename": "doc/source/user/etsi_vnf_healing.rst",
"patchSetId": 23
},
"lineNbr": 574,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "In the current v1 API, two vimConnectionInfo are set.\nIs it okay to write the results according to the current specifications in the current document?",
"parentUuid": "746e0c32_599440fe",
"range": {
"startLine": 567,
"startChar": 0,
"endLine": 574,
"endChar": 41
},
"revId": "565f4ed0ac412970615e38a212277ca843e8a259",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
700b6a3bfdcd511a0e665a21546721b3305a369f Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "a984e8f1_7a59b157",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 28
},
"lineNbr": 0,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "700b6a3bfdcd511a0e665a21546721b3305a369f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

84
f03ec0f42e1115330d5999ddcea82a233c593fd0
View File

@ -34,6 +34,24 @@
"revId": "f03ec0f42e1115330d5999ddcea82a233c593fd0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8db6ddd0_2126711b",
"filename": "doc/source/user/v2/cnf/deployment/img/deployment.pu",
"patchSetId": 25
},
"lineNbr": 1,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "Thank you for the comment.\nI changed tabs to spaces in PS26.\nAnd in PS27, I removed unnecessary spaces and corrected indentation.",
"parentUuid": "1467890a_590ca48f",
"revId": "f03ec0f42e1115330d5999ddcea82a233c593fd0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -57,6 +75,30 @@
"revId": "f03ec0f42e1115330d5999ddcea82a233c593fd0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f87a518e_6c811b89",
"filename": "doc/source/user/v2/getting_started/index.rst",
"patchSetId": 25
},
"lineNbr": 16,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "Copyright has been removed in PS28.",
"parentUuid": "9fc43e81_eb81c301",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 16,
"endChar": 0
},
"revId": "f03ec0f42e1115330d5999ddcea82a233c593fd0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -80,6 +122,30 @@
"revId": "f03ec0f42e1115330d5999ddcea82a233c593fd0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8313d474_4ee50352",
"filename": "doc/source/user/v2/vnf/deployment_with_tosca/index.rst",
"patchSetId": 25
},
"lineNbr": 2,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "Thank you for pointing it out.\nBoth documents for cases using UserData, and the v2 API does not support conversion from TOSCA. \nIn PS28, I have revised the description and deleted unnecessary files.",
"parentUuid": "61335523_643bd0c8",
"range": {
"startLine": 2,
"startChar": 34,
"endLine": 2,
"endChar": 44
},
"revId": "f03ec0f42e1115330d5999ddcea82a233c593fd0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -96,6 +162,24 @@
"message": "Does it be needed to store this file because there is a procedure in the document to get it by wget [1]?\n\n[1] https://review.opendev.org/c/openstack/tacker/+/900748/25/doc/source/user/etsi_getting_started.rst#250",
"revId": "f03ec0f42e1115330d5999ddcea82a233c593fd0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1ea6e23a_6205740b",
"filename": "samples/etsi_getting_started/tosca/sample_vnf_package_csar/Files/images/cirros-0.5.2-x86_64-disk.img",
"patchSetId": 25
},
"lineNbr": 0,
"author": {
"id": 31668
},
"writtenOn": "2024-03-13T10:28:31Z",
"side": 1,
"message": "All files included in the VNF Package were placed in this folder.\nI deleted the following files that have the steps to retrieve them in PS28.\n* cirros-0.5.2-x86_64-disk.img\n* etsi_nfv_sol001_common_types.yaml\n* etsi_nfv_sol001_vnfd_types.yaml",
"parentUuid": "cf4fa797_764ccd05",
"revId": "f03ec0f42e1115330d5999ddcea82a233c593fd0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}