openstack
/
tacker
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 4149 \u003c4149@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Itsuro Oda replied on the change"}
Attention: {"person_ident":"Gerrit User 31072 \u003c31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Itsuro Oda replied on the change"}
This commit is contained in:
Gerrit User 4149 2021-12-22 23:16:33 +00:00 committed by Gerrit Code Review
parent 5a5c1631d2
commit 6295bd1c81
2 changed files with 81 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
5fe32c386a1207294b8a1c5ea35274556d7d4b44
View File

@ -76,6 +76,30 @@
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "974c11f1_f8e15d9d",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 3
},
"lineNbr": 152,
"author": {
"id": 4149
},
"writtenOn": "2021-12-22T23:16:33Z",
"side": 1,
"message": "instantiatedVnfInfo may be re-created by infra_driver. so it is not guaranteed that scaleStatus is left. (see. infra_drivers/openstack/openstack.py L.699)",
"parentUuid": "36f1b773_e1039884",
"range": {
"startLine": 149,
"startChar": 0,
"endLine": 152,
"endChar": 73
},
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -93,6 +117,24 @@
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4d189574_247d3213",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 3
},
"lineNbr": 156,
"author": {
"id": 4149
},
"writtenOn": "2021-12-22T23:16:33Z",
"side": 1,
"message": "I see. I will add a comment.",
"parentUuid": "43b727cf_8c6ee167",
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -109,6 +151,24 @@
"message": "I think that the initial value is 1 because the default value according to the SOL definition is 1, so it\u0027s better to write a comment.",
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "adf8a118_bca4028e",
"filename": "tacker/sol_refactored/controller/vnflcm_v2.py",
"patchSetId": 3
},
"lineNbr": 244,
"author": {
"id": 4149
},
"writtenOn": "2021-12-22T23:16:33Z",
"side": 1,
"message": "I see. I will add a comment.",
"parentUuid": "0e4a0d8d_6e50c8c8",
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
9fb9531ef7031161b2f037cf1816b4b8d79da82a Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "00f0de6d_394f19cf",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2021-12-22T23:16:33Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "9fb9531ef7031161b2f037cf1816b4b8d79da82a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}