Fix E713 and F811 errors in tacker code
This Patch fixes all E713 and F811 errors and enables this test for all new patches to tacker. E713 test for membership should be ‘not in’ F811 redefinition of unused variable see OpenStack Style Guidelines http://docs.openstack.org/developer/hacking/ Change-Id: I2f73c11bb5f89b3d3c2a85417ad5098fd21e580d Related-Bug: 1515930
This commit is contained in:
parent
c43231fc8e
commit
72d421a102
@ -81,7 +81,7 @@ class DeviceHeat(abstract_driver.DeviceAbstractDriver):
|
||||
|
||||
device_template_dict.update(
|
||||
dict((key, vnfd_dict[vnfd_key]) for (key, vnfd_key) in KEY_LIST
|
||||
if ((not key in device_template_dict or
|
||||
if ((key not in device_template_dict or
|
||||
device_template_dict[key] == '') and
|
||||
vnfd_key in vnfd_dict and
|
||||
vnfd_dict[vnfd_key] != '')))
|
||||
|
@ -205,7 +205,7 @@ class ActionPolicy(object):
|
||||
def get_supported_actions(cls):
|
||||
return cls._POLICIES.keys()
|
||||
|
||||
@abc.abstractmethod
|
||||
@abc.abstractmethod # noqa
|
||||
def execute_action(cls, plugin, device_dict):
|
||||
pass
|
||||
|
||||
|
4
tox.ini
4
tox.ini
@ -59,11 +59,9 @@ commands = {posargs}
|
||||
# E126 continuation line over-indented for hanging indent
|
||||
# E128 continuation line under-indented for visual indent
|
||||
# E129 visually indented line with same indent as next logical line
|
||||
# E713 test for membership should be ‘not in’
|
||||
# F811 redefinition of unused variable
|
||||
# H302 import only modules
|
||||
# H904 Wrap long lines in parentheses instead of a backslash
|
||||
ignore = E125,E126,E128,E129,E713,F811,H302,H904
|
||||
ignore = E125,E126,E128,E129,H302,H904
|
||||
show-source = true
|
||||
builtins = _
|
||||
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,.ropeproject
|
||||
|
Loading…
Reference in New Issue
Block a user