openstack
/
tacker
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+1

(7 comments)

Patch-set: 4
Reviewer: Gerrit User 31072 <31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 31668 \u003c31668@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Hiroo Kitamura replied on the change"}
Attention: {"person_ident":"Gerrit User 31072 \u003c31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Hiroo Kitamura replied on the change"}
This commit is contained in:
Gerrit User 31072 2022-05-11 23:37:17 +00:00 committed by Gerrit Code Review
parent 4307216763
commit 738042c021
2 changed files with 161 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
33d22827c3a2fa4ba9c462409c188ce0c0fc024e
View File

@ -33,6 +33,23 @@
"message": "recheck",
"revId": "33d22827c3a2fa4ba9c462409c188ce0c0fc024e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4f742dfc_4db0857b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 31072
},
"writtenOn": "2022-05-11T23:37:17Z",
"side": 1,
"message": "LGTM",
"revId": "33d22827c3a2fa4ba9c462409c188ce0c0fc024e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

144
91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc
View File

@ -47,6 +47,30 @@
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "76bed4a0_9e972db4",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 16,
"author": {
"id": 31072
},
"writtenOn": "2022-05-11T23:37:17Z",
"side": 1,
"message": "Done",
"parentUuid": "21248306_1630f2ea",
"range": {
"startLine": 16,
"startChar": 5,
"endLine": 16,
"endChar": 12
},
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -94,6 +118,30 @@
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "558f3652_ce7c7df3",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 19,
"author": {
"id": 31072
},
"writtenOn": "2022-05-11T23:37:17Z",
"side": 1,
"message": "Done",
"parentUuid": "4035af90_c6d9189e",
"range": {
"startLine": 19,
"startChar": 5,
"endLine": 19,
"endChar": 12
},
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -141,6 +189,30 @@
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cd9f361b_97a25624",
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
"patchSetId": 2
},
"lineNbr": 669,
"author": {
"id": 31072
},
"writtenOn": "2022-05-11T23:37:17Z",
"side": 1,
"message": "Done",
"parentUuid": "84bc8497_5f511339",
"range": {
"startLine": 668,
"startChar": 8,
"endLine": 669,
"endChar": 28
},
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -188,6 +260,30 @@
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "25aec1c6_4f6e7227",
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
"patchSetId": 2
},
"lineNbr": 710,
"author": {
"id": 31072
},
"writtenOn": "2022-05-11T23:37:17Z",
"side": 1,
"message": "Done",
"parentUuid": "3ad23dac_59fc7398",
"range": {
"startLine": 709,
"startChar": 8,
"endLine": 710,
"endChar": 28
},
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -235,6 +331,30 @@
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6302d371_6e0e6afa",
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
"patchSetId": 2
},
"lineNbr": 2664,
"author": {
"id": 31072
},
"writtenOn": "2022-05-11T23:37:17Z",
"side": 1,
"message": "Done",
"parentUuid": "3dfb81e1_6d7bbb6b",
"range": {
"startLine": 2663,
"startChar": 8,
"endLine": 2664,
"endChar": 28
},
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -281,6 +401,30 @@
},
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0204f15d_df41691d",
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
"patchSetId": 2
},
"lineNbr": 2704,
"author": {
"id": 31072
},
"writtenOn": "2022-05-11T23:37:17Z",
"side": 1,
"message": "Done",
"parentUuid": "99602bb9_36b20d57",
"range": {
"startLine": 2703,
"startChar": 8,
"endLine": 2704,
"endChar": 28
},
"revId": "91db62fe8fafeba9fc8a4a835e93bc316fc6c0bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}