openstack
/
tacker
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(3 comments)

Contents looks good. Few suggestions to make this generic...

Patch-set: 3
Label: Code-Review=-1
This commit is contained in:
Gerrit User 13380 2016-02-10 22:56:31 +00:00 committed by Gerrit Code Review
parent f0789ae9c1
commit 92b4afe048
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
8a16f0a6268bf725130a26e9318e1e411d36fe0c Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "3a57f1b5_be12df07",
"filename": "doc/source/devref/ubuntu_1404_manual_installation.rst",
"patchSetId": 3
},
"lineNbr": 1,
"author": {
"id": 13380
},
"writtenOn": "2016-02-10T22:56:31Z",
"side": 1,
"message": "It is better to write this manual install doc a bit generically that would be applicable for any OpenStack distro (RHEL, Ubuntu, etc). So I\u0027d suggest to name this file as manual_installation.rst as it was originally proposed.",
"revId": "8a16f0a6268bf725130a26e9318e1e411d36fe0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a57f1b5_a10f22e0",
"filename": "doc/source/devref/ubuntu_1404_manual_installation.rst",
"patchSetId": 3
},
"lineNbr": 24,
"author": {
"id": 13380
},
"writtenOn": "2016-02-10T22:56:31Z",
"side": 1,
"message": "Again, lets not make this specific any distro. Expect for pkg installer (apt-get vs rpm) nothing would actually tie this document to a specific linux distro.",
"revId": "8a16f0a6268bf725130a26e9318e1e411d36fe0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a57f1b5_813d46bd",
"filename": "doc/source/devref/ubuntu_1404_manual_installation.rst",
"patchSetId": 3
},
"lineNbr": 247,
"author": {
"id": 13380
},
"writtenOn": "2016-02-10T22:56:31Z",
"side": 1,
"message": "I\u0027d suggest to move this section into a separate file called \u0027Getting Started\u0027 rst",
"revId": "8a16f0a6268bf725130a26e9318e1e411d36fe0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}