Update patch set 4

Patch Set 4: Code-Review-1

(2 comments)

Looks good. Few minor comments...

Patch-set: 4
Label: Code-Review=-1
This commit is contained in:
Gerrit User 13380 2016-01-20 07:22:53 +00:00 committed by Gerrit Code Review
parent 9026c87d2d
commit 93a36fbafa
1 changed files with 44 additions and 0 deletions

View File

@ -0,0 +1,44 @@
{
"comments": [
{
"key": {
"uuid": "ba63e191_e69f5eb2",
"filename": "devstack/lib/tacker",
"patchSetId": 4
},
"lineNbr": 382,
"author": {
"id": 13380
},
"writtenOn": "2016-01-20T07:22:53Z",
"side": 1,
"message": "Again, indentation needs to be consistent for L382-L384.",
"range": {
"startLine": 382,
"startChar": 8,
"endLine": 382,
"endChar": 19
},
"revId": "e6fdd54025399e481c496651241c37940210de01",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba63e191_4698aac0",
"filename": "devstack/lib/tacker",
"patchSetId": 4
},
"lineNbr": 384,
"author": {
"id": 13380
},
"writtenOn": "2016-01-20T07:22:53Z",
"side": 1,
"message": "Can you print the outcome of command, perhaps the Glance ID returned, below this line ? It would help debug any issues in the gate tests.",
"revId": "e6fdd54025399e481c496651241c37940210de01",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}