Update patch set 12
Patch Set 12: Code-Review-1 (3 comments) Patch-set: 12 Reviewer: Gerrit User 32102 <32102@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 34346 \u003c34346@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Manpreet Kaur replied on the change"} Attention: {"person_ident":"Gerrit User 32102 \u003c32102@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Manpreet Kaur replied on the change"}
This commit is contained in:
parent
f1165ff578
commit
9ef22b274b
|
@ -0,0 +1,67 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"unresolved": false,
|
||||||
|
"key": {
|
||||||
|
"uuid": "eeedd660_89d7b4ff",
|
||||||
|
"filename": "/PATCHSET_LEVEL",
|
||||||
|
"patchSetId": 12
|
||||||
|
},
|
||||||
|
"lineNbr": 0,
|
||||||
|
"author": {
|
||||||
|
"id": 32102
|
||||||
|
},
|
||||||
|
"writtenOn": "2022-05-11T13:37:19Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Thanks for your patch, there are few comments.",
|
||||||
|
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "433f6ddf_c0a7a309",
|
||||||
|
"filename": "tacker/api/vnfpkgm/v1/controller.py",
|
||||||
|
"patchSetId": 12
|
||||||
|
},
|
||||||
|
"lineNbr": 300,
|
||||||
|
"author": {
|
||||||
|
"id": 32102
|
||||||
|
},
|
||||||
|
"writtenOn": "2022-05-11T13:37:19Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "In my understanding this \"if\" condition validates whether range_.end is None or not? If the above assumption is correct then should we check the using \"is not\" operator.\nPlease let me know your opinion.",
|
||||||
|
"range": {
|
||||||
|
"startLine": 300,
|
||||||
|
"startChar": 12,
|
||||||
|
"endLine": 300,
|
||||||
|
"endChar": 26
|
||||||
|
},
|
||||||
|
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "2b1d6bdd_a18def2f",
|
||||||
|
"filename": "tacker/tests/functional/sol/vnfpkgm/test_vnf_package.py",
|
||||||
|
"patchSetId": 12
|
||||||
|
},
|
||||||
|
"lineNbr": 468,
|
||||||
|
"author": {
|
||||||
|
"id": 32102
|
||||||
|
},
|
||||||
|
"writtenOn": "2022-05-11T13:37:19Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Suggestion: If possible please use f-string, its more readable.",
|
||||||
|
"range": {
|
||||||
|
"startLine": 468,
|
||||||
|
"startChar": 17,
|
||||||
|
"endLine": 468,
|
||||||
|
"endChar": 61
|
||||||
|
},
|
||||||
|
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue