openstack
/
tacker
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 31668 \u003c31668@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Itsuro Oda replied on the change"}
Attention: {"person_ident":"Gerrit User 4149 \u003c4149@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Itsuro Oda replied on the change"}
This commit is contained in:
Gerrit User 4149 2022-04-19 22:16:38 +00:00 committed by Gerrit Code Review
parent 8797d192e2
commit 9f3e2c7136
2 changed files with 89 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
15d2e110bc8073e868c3b02cd40964cec1498b53
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "7fd505d5_e382302c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2022-04-19T22:16:38Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "15d2e110bc8073e868c3b02cd40964cec1498b53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -23,6 +40,30 @@
"revId": "15d2e110bc8073e868c3b02cd40964cec1498b53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "98c8c076_1c68b16e",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 4
},
"lineNbr": 340,
"author": {
"id": 4149
},
"writtenOn": "2022-04-19T22:16:38Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "c95bcc03_308431ef",
"range": {
"startLine": 339,
"startChar": 4,
"endLine": 340,
"endChar": 35
},
"revId": "15d2e110bc8073e868c3b02cd40964cec1498b53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -45,6 +86,30 @@
},
"revId": "15d2e110bc8073e868c3b02cd40964cec1498b53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0567bd0d_b629ae04",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 4
},
"lineNbr": 345,
"author": {
"id": 4149
},
"writtenOn": "2022-04-19T22:16:38Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "262b9626_4de94711",
"range": {
"startLine": 344,
"startChar": 4,
"endLine": 345,
"endChar": 35
},
"revId": "15d2e110bc8073e868c3b02cd40964cec1498b53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

24
f00c2154c60abc7250ce6752e1892a70510a2a74
View File

@ -105,6 +105,30 @@
"revId": "f00c2154c60abc7250ce6752e1892a70510a2a74",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "339b5779_8a757c4a",
"filename": "tacker/sol_refactored/api/wsgi.py",
"patchSetId": 2
},
"lineNbr": 190,
"author": {
"id": 4149
},
"writtenOn": "2022-04-19T22:16:38Z",
"side": 1,
"message": "OK, I see. I will change.",
"parentUuid": "7757ed51_2b1f2b70",
"range": {
"startLine": 189,
"startChar": 8,
"endLine": 190,
"endChar": 63
},
"revId": "f00c2154c60abc7250ce6752e1892a70510a2a74",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {