openstack
/
tacker
Code Issues Proposed changes

Update patch set 11 

Patch Set 11: Code-Review-1

(9 comments)

Patch-set: 11
Reviewer: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 2b78eba23feebd2e3c297e5ddddfbed9dcc864e3
Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31857\u003e replied on the change"}
This commit is contained in:
Gerrit User 31857 2024-03-14 07:28:13 +00:00 committed by Gerrit Code Review
parent 9584271b99
commit a0345a7ad6
1 changed files with 201 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

201
a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc
View File

@ -1,5 +1,137 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "55f36685_5fd873a0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 11
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "Thanks for your patch, please kindly find my comments.",
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f77a095e_7085238e",
"filename": "doc/source/install/openstack_helm.rst",
"patchSetId": 11
},
"lineNbr": 30,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "Could you match the length of the sentence above?",
"range": {
"startLine": 30,
"startChar": 58,
"endLine": 30,
"endChar": 59
},
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "52dafb8f_b81c5b58",
"filename": "doc/source/install/openstack_helm.rst",
"patchSetId": 11
},
"lineNbr": 44,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "nit: install",
"range": {
"startLine": 44,
"startChar": 19,
"endLine": 44,
"endChar": 26
},
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f783d8d7_13444699",
"filename": "doc/source/install/openstack_helm.rst",
"patchSetId": 11
},
"lineNbr": 53,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "nit: OpenStack",
"range": {
"startLine": 53,
"startChar": 9,
"endLine": 53,
"endChar": 18
},
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d0212a8c_f4564ea5",
"filename": "doc/source/install/openstack_helm.rst",
"patchSetId": 11
},
"lineNbr": 55,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "nit: install",
"range": {
"startLine": 55,
"startChar": 19,
"endLine": 55,
"endChar": 26
},
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "da21f45b_17ae889d",
"filename": "doc/source/install/openstack_helm.rst",
"patchSetId": 11
},
"lineNbr": 61,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "This reference does not appear to list the installation of `Barbican`, that is describe as pre-requisites in manual installation guide [1]. Shouldn\u0027t it be describe as a note or how to install barbican in this document?\n\n[1] https://docs.openstack.org/tacker/latest/install/manual_installation.html#pre-requisites",
"range": {
"startLine": 61,
"startChar": 5,
"endLine": 61,
"endChar": 27
},
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +218,29 @@
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b7bfa097_d5768597",
"filename": "doc/source/install/openstack_helm.rst",
"patchSetId": 11
},
"lineNbr": 102,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "`TACKER_ENDPOINT` is not used in this installation guide.",
"range": {
"startLine": 102,
"startChar": 7,
"endLine": 102,
"endChar": 63
},
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -102,6 +257,52 @@
"message": "Just a question. The user account and password are valid on other than your environment because I\u0027m not sure where it\u0027s defined?",
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7698ff71_dad96bb1",
"filename": "doc/source/install/openstack_helm.rst",
"patchSetId": 11
},
"lineNbr": 124,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "How can user get this IP address?\nIs it possible to access without port forwarding? If there is any necessary procedure, could you write it?",
"range": {
"startLine": 124,
"startChar": 28,
"endLine": 124,
"endChar": 43
},
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "078e816a_9b9a439f",
"filename": "doc/source/install/openstack_helm.rst",
"patchSetId": 11
},
"lineNbr": 124,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T07:28:13Z",
"side": 1,
"message": "Don\u0027t you need to do it inside `TACKER_SERVER_POD`, just like keystone token retrieval?\nIf this is possible, wouldn\u0027t it be possible to get a token for keystone without execution in TACKER_ POD?",
"range": {
"startLine": 124,
"startChar": 7,
"endLine": 124,
"endChar": 117
},
"revId": "a2c2d6be8ce1b965b0f550ed8c7dae8b1bb4e8fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}