openstack
/
tacker
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(4 comments)

Patch-set: 12
This commit is contained in:
Gerrit User 32102 2022-05-11 14:24:32 +00:00 committed by Gerrit Code Review
parent 9ef22b274b
commit a117431d9b
1 changed files with 86 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
1dc24894ef8f4423b32066c11ea75f3fa12d116a
View File

@ -17,6 +17,23 @@
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0527cbb1_54862490",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 32102
},
"writtenOn": "2022-05-11T14:24:32Z",
"side": 1,
"message": "Sorry for additional comments/suggestions.",
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -62,6 +79,75 @@
},
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d7f280ac_686662df",
"filename": "tacker/tests/functional/sol/vnfpkgm/test_vnf_package.py",
"patchSetId": 12
},
"lineNbr": 542,
"author": {
"id": 32102
},
"writtenOn": "2022-05-11T14:24:32Z",
"side": 1,
"message": "Could you add test description as \"Invalid Range: \u003ctest case description\u003e\" as this is will be easy to understand. What do you think?",
"range": {
"startLine": 542,
"startChar": 8,
"endLine": 542,
"endChar": 48
},
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "512c7e82_489791d0",
"filename": "tacker/tests/functional/sol/vnfpkgm/test_vnf_package.py",
"patchSetId": 12
},
"lineNbr": 556,
"author": {
"id": 32102
},
"writtenOn": "2022-05-11T14:24:32Z",
"side": 1,
"message": "ditto, \"Invalid End Range: \u003ctest case description\u003e\".",
"range": {
"startLine": 556,
"startChar": 7,
"endLine": 556,
"endChar": 61
},
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1d87268b_d038c4bb",
"filename": "tacker/tests/functional/sol/vnfpkgm/test_vnf_package.py",
"patchSetId": 12
},
"lineNbr": 569,
"author": {
"id": 32102
},
"writtenOn": "2022-05-11T14:24:32Z",
"side": 1,
"message": "ditto, \"Invalid Start Range: \u003ctest case description\u003e\".",
"range": {
"startLine": 569,
"startChar": 7,
"endLine": 569,
"endChar": 51
},
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}