openstack
/
tacker
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(5 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 33492 \u003c33492@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Yi Feng replied on the change"}
Attention: {"person_ident":"Gerrit User 25701 \u003c25701@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Yi Feng replied on the change"}
Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Yi Feng replied on the change"}
This commit is contained in:
Gerrit User 33492 2022-04-20 07:25:02 +00:00 committed by Gerrit Code Review
parent b013b6c33d
commit a2898584ff
2 changed files with 111 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
6a0ba25f122ad3944c4a07f28f7893b85070c6be Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "9d4dc9a1_8f42144d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 33492
},
"writtenOn": "2022-04-20T07:25:02Z",
"side": 1,
"message": "To Ayumu Ueha, Yasufumi Ogawa:\nThank you for your comments. I fixed them in PS7.\nPlease kindly check them again.",
"revId": "6a0ba25f122ad3944c4a07f28f7893b85070c6be",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

90
c52343a974b05fe880bd01977bd82641cc0f2a8c
View File

@ -23,6 +23,30 @@
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "708b3ca2_d4487b2a",
"filename": ".zuul.yaml",
"patchSetId": 6
},
"lineNbr": 443,
"author": {
"id": 33492
},
"writtenOn": "2022-04-20T07:25:02Z",
"side": 1,
"message": "I fixed it in PS7.",
"parentUuid": "298e622f_209c3caf",
"range": {
"startLine": 442,
"startChar": 0,
"endLine": 443,
"endChar": 105
},
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1ad29a6e_73aa48a1",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 32,
"author": {
"id": 33492
},
"writtenOn": "2022-04-20T07:25:02Z",
"side": 1,
"message": "I made it shorter in PS7.",
"parentUuid": "e5a3af88_b5910774",
"range": {
"startLine": 9,
"startChar": 0,
"endLine": 32,
"endChar": 22
},
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -97,6 +145,24 @@
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8f9ab91a_371a06e1",
"filename": "tacker/vnfm/infra_drivers/kubernetes/k8s/translate_outputs.py",
"patchSetId": 6
},
"lineNbr": 166,
"author": {
"id": 33492
},
"writtenOn": "2022-04-20T07:25:02Z",
"side": 1,
"message": "I fixed it in PS7.",
"parentUuid": "a3b4a8e6_738e0242",
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -119,6 +185,30 @@
},
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "559fc8ae_fa718138",
"filename": "tacker/vnfm/infra_drivers/kubernetes/k8s/translate_outputs.py",
"patchSetId": 6
},
"lineNbr": 167,
"author": {
"id": 33492
},
"writtenOn": "2022-04-20T07:25:02Z",
"side": 1,
"message": "I make a variable to store it.",
"parentUuid": "73964e2c_d032e426",
"range": {
"startLine": 167,
"startChar": 33,
"endLine": 167,
"endChar": 75
},
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}