openstack/tacker
Code Issues Proposed changes

Fix to use . to source script files

Browse Source 
Adhering to coding conventions. Refer to ``Code conventions`` at
https://docs.openstack.org/contributor-guide/ for details.
When you have to source a script file, for example, a credentials file
to gain access to user-only or admin-only CLI commands, use . instead of source.
https://docs.openstack.org/contributor-guide/writing-style/code-conventions.html

Change-Id: I267e2282345b5cb97eba8d0c844417354ec24f4c
This commit is contained in:
rajat29 2017-09-05 12:40:49 +05:30
parent 5d8856e1b1
commit ab6a2557d4
8 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
devstack/lib/tacker
View File

@ -427,13 +427,13 @@ function tacker_register_default_vim {
$TOP_DIR/tools/create_userrc.sh -P -u $DEFAULT_VIM_USER -C $DEFAULT_VIM_PROJECT_NAME -p $DEFAULT_VIM_PASSWORD $TOP_DIR/tools/create_userrc.sh -P -u $DEFAULT_VIM_USER -C $DEFAULT_VIM_PROJECT_NAME -p $DEFAULT_VIM_PASSWORD
echo "Switch environment openrc:" echo "Switch environment openrc:"
echo $(cat $TOP_DIR/accrc/$DEFAULT_VIM_PROJECT_NAME/$DEFAULT_VIM_USER) echo $(cat $TOP_DIR/accrc/$DEFAULT_VIM_PROJECT_NAME/$DEFAULT_VIM_USER)
source $TOP_DIR/accrc/$DEFAULT_VIM_PROJECT_NAME/$DEFAULT_VIM_USER . $TOP_DIR/accrc/$DEFAULT_VIM_PROJECT_NAME/$DEFAULT_VIM_USER
default_vim_id=$(tacker vim-register --is-default --description "Default VIM" --config-file $VIM_CONFIG_FILE $DEFAULT_VIM_NAME -c id | grep id | awk '{print $4}') default_vim_id=$(tacker vim-register --is-default --description "Default VIM" --config-file $VIM_CONFIG_FILE $DEFAULT_VIM_NAME -c id | grep id | awk '{print $4}')
echo "Default VIM registration done as $default_vim_id at $KEYSTONE_SERVICE_URI." echo "Default VIM registration done as $default_vim_id at $KEYSTONE_SERVICE_URI."
echo "Switch back to old environment openrc:" echo "Switch back to old environment openrc:"
echo $(cat $TOP_DIR/accrc/$old_project/$old_user) echo $(cat $TOP_DIR/accrc/$old_project/$old_user)
source $TOP_DIR/accrc/$old_project/$old_user . $TOP_DIR/accrc/$old_project/$old_user
echo "Update tacker/tests/etc/samples/local-vim.yaml for functional testing" echo "Update tacker/tests/etc/samples/local-vim.yaml for functional testing"
functional_vim_file="$TACKER_DIR/tacker/tests/etc/samples/local-vim.yaml" functional_vim_file="$TACKER_DIR/tacker/tests/etc/samples/local-vim.yaml"

6
devstack/local.sh.mysql_fix
View File

@ -13,10 +13,10 @@
TOP_DIR=$(cd $(dirname "$0") && pwd) TOP_DIR=$(cd $(dirname "$0") && pwd)
# Import common functions # Import common functions
source $TOP_DIR/functions . $TOP_DIR/functions
# Use openrc + stackrc + localrc for settings # Use openrc + stackrc + localrc for settings
source $TOP_DIR/stackrc . $TOP_DIR/stackrc
# Destination path for installation ``DEST`` # Destination path for installation ``DEST``
DEST=${DEST:-/opt/stack} DEST=${DEST:-/opt/stack}
@ -38,7 +38,7 @@ if is_service_enabled mysql; then
exit_distro_not_supported "mysql configuration" exit_distro_not_supported "mysql configuration"
fi fi
sudo bash -c "source $TOP_DIR/functions && \ sudo bash -c ". $TOP_DIR/functions && \
iniset $my_conf mysqld max_connections 1024 && \ iniset $my_conf mysqld max_connections 1024 && \
iniset $my_conf mysqld query_cache_type OFF && \ iniset $my_conf mysqld query_cache_type OFF && \
iniset $my_conf mysqld query_cache_size 0" iniset $my_conf mysqld query_cache_size 0"

2
devstack/plugin.sh
View File

@ -5,7 +5,7 @@ XTRACE=$(set +o | grep xtrace)
set -o xtrace set -o xtrace
echo_summary "tacker's plugin.sh was called..." echo_summary "tacker's plugin.sh was called..."
source $DEST/tacker/devstack/lib/tacker . $DEST/tacker/devstack/lib/tacker
(set -o posix; set) (set -o posix; set)
# check for service enabled # check for service enabled

2
doc/source/contributor/encrypt_vim_auth_with_barbican.rst
View File

@ -41,7 +41,7 @@ Create a vim and verify it works:
.. code-block:: bash .. code-block:: bash
$ source openrc-admin.sh $ . openrc-admin.sh
$ openstack project create test $ openstack project create test
$ openstack user create --password a test $ openstack user create --password a test
$ openstack role add --project test --user test admin $ openstack role add --project test --user test admin

4
tacker/tests/contrib/post_test_hook.sh
View File

@ -53,14 +53,14 @@ function generate_testr_results {
fi fi
} }
source ${TACKER_DIR}/tacker/tests/contrib/post_test_hook_lib.sh . ${TACKER_DIR}/tacker/tests/contrib/post_test_hook_lib.sh
if [[ "$venv" == dsvm-functional* ]] if [[ "$venv" == dsvm-functional* ]]
then then
owner=stack owner=stack
sudo_env= sudo_env=
log_dir="/tmp/${venv}-logs" log_dir="/tmp/${venv}-logs"
source $DEVSTACK_DIR/openrc admin admin . $DEVSTACK_DIR/openrc admin admin
fixup_quota fixup_quota
add_key add_key
add_secgrp add_secgrp

2
tools/install_venv.py
View File

@ -40,7 +40,7 @@ def print_help():
To activate the Tacker virtualenv for the extent of your current shell To activate the Tacker virtualenv for the extent of your current shell
session you can run: session you can run:
$ source .venv/bin/activate $ . .venv/bin/activate
Or, if you prefer, you can run commands in the virtualenv on a case by case Or, if you prefer, you can run commands in the virtualenv on a case by case
basis by running: basis by running:

4
tools/prepare_functional_test.sh
View File

@ -12,8 +12,8 @@ if [ ! -f ${DEVSTACK_DIR}/openrc ]; then
exit 1 exit 1
fi fi
source $DEVSTACK_DIR/openrc admin admin . $DEVSTACK_DIR/openrc admin admin
source ${TACKER_DIR}/tacker/tests/contrib/post_test_hook_lib.sh . ${TACKER_DIR}/tacker/tests/contrib/post_test_hook_lib.sh
fixup_quota fixup_quota
add_key_if_not_exist add_key_if_not_exist

2
tools/with_venv.sh
View File

@ -17,4 +17,4 @@
TOOLS=`dirname $0` TOOLS=`dirname $0`
VENV=$TOOLS/../.venv VENV=$TOOLS/../.venv
source $VENV/bin/activate && "$@" . $VENV/bin/activate && "$@"