Update patch set 1
Patch Set 1: Code-Review-1 (3 comments) Thanks Abdul. Aqsa, can you please look into this as to why the IP is assigned on br-lan? Also provided few comments on the patchset. Thanks! Patch-set: 1 Label: Code-Review=-1
This commit is contained in:
parent
50a4062241
commit
abf829f154
|
@ -0,0 +1,55 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a710552_14d43a1e",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 13,
|
||||
"author": {
|
||||
"id": 13485
|
||||
},
|
||||
"writtenOn": "2015-12-15T19:19:59Z",
|
||||
"side": 1,
|
||||
"message": "Please follow the guidelines in [1] for writing commit message title and description.\n\n1st line 50 char.\nAfter 1st line 72 char.\n\nThis will be helpful for git log messages\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure",
|
||||
"revId": "b62dadab2c0d38ae4ea9242299535e1bd036194d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a710552_b491a654",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 16,
|
||||
"author": {
|
||||
"id": 13485
|
||||
},
|
||||
"writtenOn": "2015-12-15T19:19:59Z",
|
||||
"side": 1,
|
||||
"message": "Shoudnt this be Closes-Bug?",
|
||||
"revId": "b62dadab2c0d38ae4ea9242299535e1bd036194d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a710552_c4d91b85",
|
||||
"filename": "devstack/samples/local.conf.example",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 52,
|
||||
"author": {
|
||||
"id": 13485
|
||||
},
|
||||
"writtenOn": "2015-12-15T19:19:59Z",
|
||||
"side": 1,
|
||||
"message": "This should be IMAGE_URLS+\u003d\u003curl\u003e . This did not get downloaded at all from the logs observed in dsvm-functional-gate.Only cirros image was downloaded. Can you please confirm this?\n\nAlso as part of this patchset, please update the openwrt template in devstack/samples dir. if the the glance image name is impacted",
|
||||
"revId": "b62dadab2c0d38ae4ea9242299535e1bd036194d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue