openstack
/
tacker
Code Issues Proposed changes

Fix failed test for creating vnf image 

The number of getting image URL is expected as `2`, but notactually
in test_pre_instantiation_vnf_image_with_file(). The value can be `1`
or `2` for `tox -e py36` or `tox -e lower-constraints`. It might be
because of a difference of versions of modules imported in
the test cases.

This update is just a quick fixing to avoid the issue. So, it could be
happened again possibly if the versions of modules are changed.

Closes-Bug: #1885523

Change-Id: I302607f636d6d96baa544ccad600bb21fdf18da2
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
This commit is contained in:
Yasufumi Ogawa 2020-06-29 07:38:41 +00:00
parent 4237fe5204
commit ad686ab846
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lower-constraints.txt
View File

@ -51,7 +51,7 @@ kombu==4.0.0
kubernetes==5.0.0
linecache2==1.0.0
Mako==1.0.7
MarkupSafe==1.0
MarkupSafe==1.1
mccabe==0.2.1
monotonic==1.4
mox3==0.25.0

2
tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py
View File

@ -886,7 +886,7 @@ class TestOpenStack(base.FixturedTestCase):
vnf_instance.id)
self.assertEqual(upload_image_url.call_count, 1)
self.assertEqual(create_image_url.call_count, 1)
self.assertEqual(get_image_url.call_count, 2)
self.assertTrue(get_image_url.call_count >= 1)
@mock.patch('tacker.common.utils.is_url', mock.MagicMock(
return_value=True))