openstack/tacker
Code Issues Proposed changes

Merge "Fix subprocess usage"

Browse Source
This commit is contained in:
Zuul 2022-03-09 10:22:31 +00:00 committed by Gerrit Code Review
commit ba8d4924e0
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tacker/sol_refactored/conductor/vnflcm_driver_v2.py
View File

@ -111,7 +111,7 @@ class VnfLcmDriverV2(object):
out = subprocess.run(["python3", script_path],
input=pickle.dumps(script_dict),
capture_output=True)
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
vnfd.remove_tmp_csar_dir(tmp_csar_dir)

5
tacker/sol_refactored/infra_drivers/openstack/openstack.py
View File

@ -335,14 +335,15 @@ class Openstack(object):
out = subprocess.run(["python3", script_path],
input=pickle.dumps(script_dict),
capture_output=True)
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
vnfd.remove_tmp_csar_dir(tmp_csar_dir)
if out.returncode != 0:
LOG.debug("execute userdata class instantiate failed: %s",
out.stderr)
raise sol_ex.UserdataExecutionFailed(sol_detail=out.stderr)
raise sol_ex.UserdataExecutionFailed(
sol_detail=str(out.stderr))
fields = pickle.loads(out.stdout)